From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-40676-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 6688 invoked by alias); 31 Aug 2005 19:37:18 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 6651 invoked by uid 22791); 31 Aug 2005 19:37:13 -0000
Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47)
    by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 31 Aug 2005 19:37:13 +0000
Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2])
	by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j7VJbAe5013992;
	Wed, 31 Aug 2005 21:37:10 +0200 (CEST)
Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1])
	by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j7VJbAUb014640;
	Wed, 31 Aug 2005 21:37:10 +0200 (CEST)
Received: (from kettenis@localhost)
	by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j7VJb6dt014705;
	Wed, 31 Aug 2005 21:37:06 +0200 (CEST)
Date: Wed, 31 Aug 2005 20:08:00 -0000
Message-Id: <200508311937.j7VJb6dt014705@elgar.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: wilson@specifix.com
CC: gdb-patches@sourceware.org
In-reply-to: <1125515044.21922.12.camel@aretha.corp.specifix.com> (message
	from James E Wilson on Wed, 31 Aug 2005 12:04:04 -0700)
Subject: Re: [patch] fix gcc4 error for freebsd target
References:  <1125515044.21922.12.camel@aretha.corp.specifix.com>
X-SW-Source: 2005-08/txt/msg00267.txt.bz2

> From: James E Wilson <wilson@specifix.com>
> Date: Wed, 31 Aug 2005 12:04:04 -0700
> 
> On an i386-freebsd4.10 machine, using gcc-4.0.1 to compile gdb-6.3, I
> get a compiler error.  The same problem still exists on gdb mainline.
> 
> ../../gdb-6.3/gdb/i386fbsd-tdep.c:48: error: static declaration of
> '386fbsd_sc_reg_offset' follows non-static declaration
> ../../gdb-6.3/gdb/i386-tdep.h:190: error: previous declaration of
> 'i386fbsd_sc_reg_offset' was here

Duh!

> The fix is trivial.  We just need to delete the static keyword from the
> i386fbsd_sc_reg_offset definition in i386fbsd-tdep.c.
> 
> I've attached the patch for gdb-6.3, which also applies with a small
> offset to mainline.  OK for mainline?  Do you want it on the gdb-6.3
> branch also perhaps?

Please apply to mainline.  The gdb 6.3 branch is dead, so there's no
point in adding this patch there too.

Thanks,

Mark