Re: [csl-am] missing SIGTRAP

[Daniel Jacobowitz <drow@false.org>]

On Fri, Apr 29, 2005 at 03:18:04PM +0100, Paul Brook wrote:
> It appears that the builtin simulators use host signal numbers to communicate 
> with gdb. This causes problems on windows hosts because SIGTRAP isn't 
> defined. The attached patch provides a definition for SIGTRAP if the host 
> doesn't have one. This probably isn't the "right way" to fix this, but it's 
> near enough for our purposes.
> 
> Applied to csl-arm-20050325-branch.
> 
> Paul
> 
> 2005-04-29  Paul Brook  <paul@codesourcery.com>
> 
> 	* gdb/remote-sim.c (SIGTRAP): Provide default defnition.
> 	* gdb/signals/signals.c (SIGRAP): Ditto.

I was going to ignore this patch for mainline, since it indeed isn't
the right way.  Then I took a look at the simulators and how much of a
PAIN it's going to be to migrate them off of host signal numbers.

Does anyone object to the inclusion of this patch?

> Index: gdb/remote-sim.c
> ===================================================================
> RCS file: /var/cvsroot/src-cvs/src/gdb/remote-sim.c,v
> retrieving revision 1.46.2.1
> diff -u -p -r1.46.2.1 remote-sim.c
> --- gdb/remote-sim.c	29 Mar 2005 02:52:05 -0000	1.46.2.1
> +++ gdb/remote-sim.c	28 Apr 2005 00:58:33 -0000
> @@ -44,6 +44,10 @@
>  #include "sim-regno.h"
>  #include "arch-utils.h"
>  
> +#ifndef SIGTRAP
> +#define SIGTRAP 5
> +#endif
> +
>  /* Prototypes */
>  
>  extern void _initialize_remote_sim (void);
> Index: gdb/signals/signals.c
> ===================================================================
> RCS file: /var/cvsroot/src-cvs/src/gdb/signals/signals.c,v
> retrieving revision 1.9
> diff -u -p -r1.9 signals.c
> --- gdb/signals/signals.c	8 Jun 2003 18:27:14 -0000	1.9
> +++ gdb/signals/signals.c	28 Apr 2005 14:47:13 -0000
> @@ -30,6 +30,10 @@
>  
>  #include <signal.h>
>  
> +#ifndef SIGTRAP
> +#define SIGTRAP 5
> +#endif
> +
>  /* Always use __SIGRTMIN if it's available.  SIGRTMIN is the lowest
>     _available_ realtime signal, not the lowest supported; glibc takes
>     several for its own use.  */


-- 
Daniel Jacobowitz
CodeSourcery, LLC