Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: paul@codesourcery.com, gdb-patches@sources.redhat.com
Subject: Re: [csl-am] missing SIGTRAP
Date: Mon, 25 Jul 2005 18:06:00 -0000	[thread overview]
Message-ID: <20050725180603.GA12217@nevyn.them.org> (raw)
In-Reply-To: <200507251759.j6PHx4M4008405@elgar.sibelius.xs4all.nl>

On Mon, Jul 25, 2005 at 07:59:04PM +0200, Mark Kettenis wrote:
>    I was going to ignore this patch for mainline, since it indeed isn't
>    the right way.  Then I took a look at the simulators and how much of a
>    PAIN it's going to be to migrate them off of host signal numbers.
> 
>    Does anyone object to the inclusion of this patch?
> 
> The problem here is the fact that the simulator tries to map host
> events and simulator events to the same thing isn't it?  I'm not too
> concerned with the simulators, but I think someone who does care
> should really fix this.  Meanwhile I don't object to a local hack in
> gdb/remote-sim.c.

No, I think that the problem is simpler than that.  The simulator
doesn't care about host events.  It's mapping target events to signal
numbers; it just picked the SIG* numbers instead of the TARGET_SIGNAL_*
numbers.  Which are only recently (in the grand scheme of things -
about three years ago) available in include/gdb/.

> However, I *do* object to the change to gdb/signals/signals.c.  This
> is supposed to be a host to target mapping of signals.  Making it
> pretend that the host has SIGTRAP while it doesn't is a truly bad
> thing to do.

Well then the hack in remote-sim.c will have to be a bit more
intrusive... it calls target_signal_to_host and target_signal_from_host
on this value.  That's doable.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


      reply	other threads:[~2005-07-25 18:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-29 14:18 Paul Brook
2005-07-25 15:04 ` Daniel Jacobowitz
2005-07-25 18:00   ` Mark Kettenis
2005-07-25 18:06     ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050725180603.GA12217@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mark.kettenis@xs4all.nl \
    --cc=paul@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox