From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4738 invoked by alias); 25 Jul 2005 15:04:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4722 invoked by uid 22791); 25 Jul 2005 15:04:56 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 25 Jul 2005 15:04:56 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1Dx4Vi-0001fA-QD; Mon, 25 Jul 2005 11:04:54 -0400 Date: Mon, 25 Jul 2005 15:04:00 -0000 From: Daniel Jacobowitz To: Paul Brook Cc: gdb-patches@sources.redhat.com Subject: Re: [csl-am] missing SIGTRAP Message-ID: <20050725150454.GA6329@nevyn.them.org> Mail-Followup-To: Paul Brook , gdb-patches@sources.redhat.com References: <200504291518.05038.paul@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200504291518.05038.paul@codesourcery.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-07/txt/msg00187.txt.bz2 On Fri, Apr 29, 2005 at 03:18:04PM +0100, Paul Brook wrote: > It appears that the builtin simulators use host signal numbers to communicate > with gdb. This causes problems on windows hosts because SIGTRAP isn't > defined. The attached patch provides a definition for SIGTRAP if the host > doesn't have one. This probably isn't the "right way" to fix this, but it's > near enough for our purposes. > > Applied to csl-arm-20050325-branch. > > Paul > > 2005-04-29 Paul Brook > > * gdb/remote-sim.c (SIGTRAP): Provide default defnition. > * gdb/signals/signals.c (SIGRAP): Ditto. I was going to ignore this patch for mainline, since it indeed isn't the right way. Then I took a look at the simulators and how much of a PAIN it's going to be to migrate them off of host signal numbers. Does anyone object to the inclusion of this patch? > Index: gdb/remote-sim.c > =================================================================== > RCS file: /var/cvsroot/src-cvs/src/gdb/remote-sim.c,v > retrieving revision 1.46.2.1 > diff -u -p -r1.46.2.1 remote-sim.c > --- gdb/remote-sim.c 29 Mar 2005 02:52:05 -0000 1.46.2.1 > +++ gdb/remote-sim.c 28 Apr 2005 00:58:33 -0000 > @@ -44,6 +44,10 @@ > #include "sim-regno.h" > #include "arch-utils.h" > > +#ifndef SIGTRAP > +#define SIGTRAP 5 > +#endif > + > /* Prototypes */ > > extern void _initialize_remote_sim (void); > Index: gdb/signals/signals.c > =================================================================== > RCS file: /var/cvsroot/src-cvs/src/gdb/signals/signals.c,v > retrieving revision 1.9 > diff -u -p -r1.9 signals.c > --- gdb/signals/signals.c 8 Jun 2003 18:27:14 -0000 1.9 > +++ gdb/signals/signals.c 28 Apr 2005 14:47:13 -0000 > @@ -30,6 +30,10 @@ > > #include > > +#ifndef SIGTRAP > +#define SIGTRAP 5 > +#endif > + > /* Always use __SIGRTMIN if it's available. SIGRTMIN is the lowest > _available_ realtime signal, not the lowest supported; glibc takes > several for its own use. */ -- Daniel Jacobowitz CodeSourcery, LLC