From: Christopher Faylor <me@cgf.cx>
To: Mark Mitchell <mark@codesourcery.com>, gdb-patches@sources.redhat.com
Subject: Re: PATCH: MinGW readline -- revised
Date: Mon, 25 Jul 2005 14:54:00 -0000 [thread overview]
Message-ID: <20050725145415.GD31264@trixie.casa.cgf.cx> (raw)
In-Reply-To: <20050725004109.GA17682@nevyn.them.org>
On Sun, Jul 24, 2005 at 08:41:09PM -0400, Daniel Jacobowitz wrote:
>On Sun, Jul 24, 2005 at 08:39:30PM -0400, Christopher Faylor wrote:
>> + #ifdef __MINGW32__
>> + /* On Windows, use a special routine to read a single character
>> + from the console. (Otherwise, no characters are available
>> + until the user hits the return key.) */
>> + if (isatty (fileno (stream)))
>> + return getch ();
>> + #endif
>
>> This doesn't look right. Shouldn't there be an ifdef there? It's a
>> minor point but it looks like this would potentially produce dead code.
>
>I'm not quite sure what you mean - but if you're talking about the code
>after the return statement, it looks like something's gone wrong with
>the indendation in this bit. Getch is only for consoles.
I forgot that getch was only for consoles. Somewhow I thought it could be
used for any stdin. Silly me. Windows.
cgf
next prev parent reply other threads:[~2005-07-25 14:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-19 0:11 Mark Mitchell
2005-07-22 7:29 ` Kai Henningsen
2005-07-24 21:10 ` Daniel Jacobowitz
2005-07-24 22:50 ` Mark Mitchell
2005-07-24 23:00 ` Daniel Jacobowitz
2005-07-24 23:03 ` Mark Mitchell
2005-07-25 0:39 ` Christopher Faylor
2005-07-25 0:41 ` Daniel Jacobowitz
2005-07-25 14:54 ` Christopher Faylor [this message]
2005-07-25 14:55 ` Mark Mitchell
2005-07-25 15:01 ` Daniel Jacobowitz
2005-07-25 15:02 ` Mark Mitchell
2005-07-25 15:10 ` Mark Mitchell
2005-07-25 0:41 ` Mark Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050725145415.GD31264@trixie.casa.cgf.cx \
--to=me@cgf.cx \
--cc=gdb-patches@sources.redhat.com \
--cc=mark@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox