Re: PATCH: MinGW readline -- revised

[Daniel Jacobowitz <drow@false.org>]

On Sun, Jul 24, 2005 at 08:39:30PM -0400, Christopher Faylor wrote:
> + #ifdef __MINGW32__
> +       /* On Windows, use a special routine to read a single  character
> +        from the console.  (Otherwise, no characters are available
> +        until the user hits the return key.)  */
> +       if (isatty (fileno (stream)))
> +       return getch ();
> + #endif

> This doesn't look right.  Shouldn't there be an ifdef there?  It's a
> minor point but it looks like this would potentially produce dead code.

I'm not quite sure what you mean - but if you're talking about the code
after the return statement, it looks like something's gone wrong with
the indendation in this bit.  Getch is only for consoles.

> Other than that I have no objections other than to add an obligatory
> grumble about the need to use a getch windows-ism.

Thanks!  Ditto.

-- 
Daniel Jacobowitz
CodeSourcery, LLC