Re: PATCH: MinGW readline -- revised

[Christopher Faylor <me@cgf.cx>]

On Sun, Jul 24, 2005 at 05:10:16PM -0400, Daniel Jacobowitz wrote:
>These look fine; the changes aren't quite the way I'd have liked them,
>but if they've been taken for readline 5.1, it's important that we
>minimize divergence.  Chris, do these parts look OK to you?

*** readline/input.c    8 Dec 2002 22:31:37 -0000       1.5
--- readline/input.c    18 Jul 2005 23:59:21 -0000
*************** rl_getc (stream)
*** 422,431 ****
--- 422,438 ----
    int result;
    unsigned char c;

    while (1)
      {
+ #ifdef __MINGW32__
+       /* On Windows, use a special routine to read a single  character
+        from the console.  (Otherwise, no characters are available
+        until the user hits the return key.)  */
+       if (isatty (fileno (stream)))
+       return getch ();
+ #endif
        result = read (fileno (stream), &c, sizeof (unsigned char));

        if (result == sizeof (unsigned char))
        return (c);


This doesn't look right.  Shouldn't there be an ifdef there?  It's a
minor point but it looks like this would potentially produce dead code.

Other than that I have no objections other than to add an obligatory
grumble about the need to use a getch windows-ism.

cgf