Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] -stack-info-frames
Date: Mon, 20 Jun 2005 13:51:00 -0000	[thread overview]
Message-ID: <20050620135108.GA29453@nevyn.them.org> (raw)
In-Reply-To: <17078.19977.660644.9978@farnswood.snap.net.nz>

On Mon, Jun 20, 2005 at 05:03:05PM +1200, Nick Roberts wrote:
> The other thing I find inappropriate about these messages is that they
> print out the name of the procedure which is not of immediate interest.

I agree.  I don't think the function or command name in all these error
messages is valuable.

> How about changing the format (for all MI commands) to
> 
> -stack-info-frame 4
> &"Usage: -stack-info-frame\n"
> ^error,msg="Usage: -stack-info-frame"
> (gdb) 
> 
> (gdb) 
> -stack-select-frame
> &"Usage: -stack-select-frame FRAME_SPEC\n"
> ^error,msg="Usage: -stack-select-frame FRAME_SPEC"
> (gdb) 
> 
> etc.
> 
> They should only occur when a developer is writing a frontend, not when it is
> being used.  The procedure name is only of interest to someone writing MI code
> For that person it should be quite easy to find the relevant code and, even if
> it was not, it should only be printed if a debug flag is set.

I like this idea; in fact, this is the style I was going to recommend
to you (until I went through and noticed that it is only used for
functions with arguments, not without, at the moment).

-- 
Daniel Jacobowitz
CodeSourcery, LLC


  reply	other threads:[~2005-06-20 13:51 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-17 22:51 Nick Roberts
2005-06-17 23:01 ` Daniel Jacobowitz
2005-06-17 23:14   ` Daniel Jacobowitz
2005-06-18  1:28     ` Nick Roberts
2005-06-18  1:58       ` Daniel Jacobowitz
2005-06-18  3:16         ` Nick Roberts
2005-06-18  8:25         ` Eli Zaretskii
2005-06-18  8:51           ` Nick Roberts
2005-06-18 10:20             ` Eli Zaretskii
2005-06-18 15:51               ` Daniel Jacobowitz
2005-06-18 22:48               ` Nick Roberts
2005-06-18 15:57             ` Daniel Jacobowitz
2005-06-18 22:48               ` Nick Roberts
2005-06-18 23:20                 ` Daniel Jacobowitz
2005-06-19  3:39                   ` Nick Roberts
2005-06-19 14:56                     ` Daniel Jacobowitz
2005-06-19 18:33                       ` Eli Zaretskii
2005-06-19 22:31                         ` Nick Roberts
2005-06-20  3:41                           ` Eli Zaretskii
2005-06-19 22:31                       ` Nick Roberts
2005-06-20  0:01                         ` Daniel Jacobowitz
2005-06-20  1:24                           ` Nick Roberts
2005-06-20  1:31                             ` Daniel Jacobowitz
2005-06-20  3:43                         ` Eli Zaretskii
2005-06-20  5:03                           ` Nick Roberts
2005-06-20 13:51                             ` Daniel Jacobowitz [this message]
2005-06-20 21:48                               ` [PATCH] MI error messages Nick Roberts
2005-06-20 22:10                                 ` Andreas Schwab
2005-06-21  3:40                                 ` Eli Zaretskii
2005-06-21  8:50                                   ` Andreas Schwab
2005-06-21  9:40                                   ` Nick Roberts
2005-06-21 19:51                                     ` Eli Zaretskii
2005-06-21 21:43                                       ` Nick Roberts
2005-06-21 21:59                                         ` Jason Molenda
2005-06-22  3:32                                           ` Daniel Jacobowitz
2005-06-22  3:41                                             ` Jason Molenda
2005-06-22  3:46                                               ` Daniel Jacobowitz
2005-06-22  7:27                                             ` Nick Roberts
2005-06-23  3:48                                               ` Daniel Jacobowitz
2005-06-22 13:04                                           ` Bob Rossi
2005-06-21 22:01                                         ` Bob Rossi
2005-06-22 11:06                                         ` Nick Roberts
2005-06-22 11:24                                           ` Andreas Schwab
2005-06-22 19:19                                           ` Jason Molenda
2005-06-22 21:55                                             ` Nick Roberts
2005-06-19 21:55                 ` [PATCH] -stack-info-frames Jason Molenda
2005-06-19 22:12                   ` Daniel Jacobowitz
2005-06-17 23:11 ` Jason Molenda
2005-06-17 23:31   ` Nick Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050620135108.GA29453@nevyn.them.org \
    --to=drow@false.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox