From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22254 invoked by alias); 20 Jun 2005 13:51:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22057 invoked by uid 22791); 20 Jun 2005 13:51:11 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 20 Jun 2005 13:51:11 +0000 Received: from drow by nevyn.them.org with local (Exim 4.51) id 1DkMg8-0007jR-9Y; Mon, 20 Jun 2005 09:51:08 -0400 Date: Mon, 20 Jun 2005 13:51:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: Eli Zaretskii , gdb-patches@sources.redhat.com Subject: Re: [PATCH] -stack-info-frames Message-ID: <20050620135108.GA29453@nevyn.them.org> Mail-Followup-To: Nick Roberts , Eli Zaretskii , gdb-patches@sources.redhat.com References: <17075.57612.684597.392526@farnswood.snap.net.nz> <20050618155742.GB3663@nevyn.them.org> <17076.42233.730605.834264@farnswood.snap.net.nz> <20050618232032.GA28368@nevyn.them.org> <17076.59646.873454.551250@farnswood.snap.net.nz> <20050619145612.GA8219@nevyn.them.org> <17077.61587.164352.664225@farnswood.snap.net.nz> <17078.19977.660644.9978@farnswood.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17078.19977.660644.9978@farnswood.snap.net.nz> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-06/txt/msg00317.txt.bz2 On Mon, Jun 20, 2005 at 05:03:05PM +1200, Nick Roberts wrote: > The other thing I find inappropriate about these messages is that they > print out the name of the procedure which is not of immediate interest. I agree. I don't think the function or command name in all these error messages is valuable. > How about changing the format (for all MI commands) to > > -stack-info-frame 4 > &"Usage: -stack-info-frame\n" > ^error,msg="Usage: -stack-info-frame" > (gdb) > > (gdb) > -stack-select-frame > &"Usage: -stack-select-frame FRAME_SPEC\n" > ^error,msg="Usage: -stack-select-frame FRAME_SPEC" > (gdb) > > etc. > > They should only occur when a developer is writing a frontend, not when it is > being used. The procedure name is only of interest to someone writing MI code > For that person it should be quite easy to find the relevant code and, even if > it was not, it should only be printed if a debug flag is set. I like this idea; in fact, this is the style I was going to recommend to you (until I went through and noticed that it is only used for functions with arguments, not without, at the moment). -- Daniel Jacobowitz CodeSourcery, LLC