Re: [PATCH] Removal of markup annotations

[Bob Rossi <bob@brasko.net>]

On Wed, Jun 15, 2005 at 03:16:03PM +1200, Nick Roberts wrote:
> 
> Here's the patch for the removal of some of the level 2 annotations that I
> referred to yesterday.  It primarily removes the markup annotations that
> worked just with level (annotation_level == 2) and leaves those which also
> worked with level 3 (annotation_level > 2).  But it also restricts
> breakpoints_changed and annotate_frames_invalid to level 2.
> breakpoints_changed doesn't get called at the moment because currently
> deprecated_delete_breakpoint_hook and deprecated_modify_breakpoint_hook have
> been set to zero in clear_interpreter_hooks.  I have already submitted a
> patch for this (2005-06-04).
> 
> This patch cleans up the code quite considerably and hopefully will relieve
> some of the pressure to remove the remaining annotations.
> 
> Nick
> 
> 
> 2005-06-15  Nick Roberts  <nickrob@snap.net.nz>
> 
> 	* annotate.c (print_value_flags, annotate_signal_name)
> 	(annotate_signal_name_end, annotate_signal_string)
> 	(annotate_signal_string_end, annotate_breakpoints_headers)
> 	(annotate_field, annotate_breakpoints_table, annotate_record)
> 	(annotate_breakpoints_table_end, annotate_field_begin)
> 	(annotate_field_name_end, annotate_field_value)
> 	(annotate_field_end, annotate_value_history_begin)
> 	(annotate_value_begin, annotate_value_history_value)
> 	(annotate_value_history_end, annotate_value_end)
> 	(annotate_display_begin, annotate_display_number_end)
> 	(annotate_display_format, annotate_display_expression)
> 	(annotate_display_expression_end, annotate_display_value)
> 	(annotate_display_end, annotate_arg_begin, annotate_arg_name_end)
> 	(annotate_arg_value, annotate_arg_end, annotate_frame_begin)
> 	(annotate_function_call, annotate_signal_handler_caller)
> 	(annotate_frame_address, annotate_frame_address_end)
> 	(annotate_frame_function_name, annotate_frame_args)
> 	(annotate_frame_source_begin, annotate_frame_source_file)
> 	(annotate_frame_source_file_end, annotate_frame_source_line)
> 	(annotate_frame_source_end, annotate_frame_where)
> 	(annotate_frame_end, annotate_array_section_begin)
> 	(annotate_elt_rep, annotate_elt_rep_end, annotate_elt)
> 	(annotate_array_section_end): Remove.
> 	(annotate_stopped): Call breakpoints_changed for level
> 	2 annotations only.
> 	(annotate_frames_invalid, _initialize_annotate): 
> 	Act only with level 2 annotations.
> 

Hi Nick,

Out of all of the annotations that you are removing here, CGDB only
depends on annotate_breakpoints_headers, annotate_field,
annotate_breakpoints_table, annotate_record and
annotate_breakpoints_table_end.

I'll have to look deeper to verify this, but if this is true, it would
really simplify my life if we could leave those in. That at least would
allow CGDB to work with the next release of GDB while I work on
GDB/MI and getting CGDB to integrate with it.

Thanks,
Bob Rossi