From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: drow@false.org
Cc: manjo@austin.ibm.com, gdb-patches@sources.redhat.com
Subject: Re: [RFC] GDBserver compiler warnings patch
Date: Mon, 13 Jun 2005 21:39:00 -0000 [thread overview]
Message-ID: <200506132138.j5DLcmgt018463@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <20050613015944.GA9288@nevyn.them.org> (message from Daniel Jacobowitz on Sun, 12 Jun 2005 21:59:44 -0400)
Date: Sun, 12 Jun 2005 21:59:44 -0400
From: Daniel Jacobowitz <drow@false.org>
Hi Daniel,
One small and one larger nit about your patch:
Index: configure.ac
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/configure.ac,v
retrieving revision 1.2
diff -u -p -r1.2 configure.ac
--- configure.ac 24 Feb 2005 20:26:32 -0000 1.2
+++ configure.ac 13 Jun 2005 01:57:11 -0000
@@ -40,10 +40,16 @@ AC_CHECK_HEADERS(sgtty.h termio.h termio
BFD_NEED_DECLARATION(strerror)
+AC_CHECK_TYPE(socklen_t,
+ [AC_DEFINE(HAVE_SOCKLEN_T, 1, [Define if you have socklen_t.])],
+ [], [#include <sys/socket.h>])
1. That AC_DEFINE is superfluous. AC_CHECK_TYPE does that for you ;-).
2. On OpenBSD (and possibly other BSD-like systems) you'll need to
#include <sys/types.h> to get socklen_t.
I propose to replace the above with what I just committed to gdb's
configure.ac:
AC_CHECK_TYPES(socklen_t, [], [],
[#include <sys/types.h>
#include <sys/socket.h>
])
Mark
next prev parent reply other threads:[~2005-06-13 21:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-01 17:47 Manoj Iyer
2005-06-06 22:26 ` Manoj Iyer
2005-06-11 23:38 ` Mark Kettenis
2005-06-13 2:00 ` Daniel Jacobowitz
2005-06-13 21:39 ` Mark Kettenis [this message]
2005-06-13 22:43 ` Daniel Jacobowitz
2005-06-14 21:37 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200506132138.j5DLcmgt018463@elgar.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=manjo@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox