From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-39935-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 23701 invoked by alias); 13 Jun 2005 21:39:27 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 23632 invoked by uid 22791); 13 Jun 2005 21:39:21 -0000
Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47)
    by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 13 Jun 2005 21:39:21 +0000
Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2])
	by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j5DLcn1a018270;
	Mon, 13 Jun 2005 23:38:49 +0200 (CEST)
Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1])
	by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j5DLcn6K014210;
	Mon, 13 Jun 2005 23:38:49 +0200 (CEST)
Received: (from kettenis@localhost)
	by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j5DLcmgt018463;
	Mon, 13 Jun 2005 23:38:48 +0200 (CEST)
Date: Mon, 13 Jun 2005 21:39:00 -0000
Message-Id: <200506132138.j5DLcmgt018463@elgar.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: drow@false.org
CC: manjo@austin.ibm.com, gdb-patches@sources.redhat.com
In-reply-to: <20050613015944.GA9288@nevyn.them.org> (message from Daniel
	Jacobowitz on Sun, 12 Jun 2005 21:59:44 -0400)
Subject: Re: [RFC] GDBserver compiler warnings patch
References: <Pine.LNX.4.58.0506011237240.5282@lazy> <20050613015944.GA9288@nevyn.them.org>
X-SW-Source: 2005-06/txt/msg00168.txt.bz2

   Date: Sun, 12 Jun 2005 21:59:44 -0400
   From: Daniel Jacobowitz <drow@false.org>

Hi Daniel,

One small and one larger nit about your patch:

   Index: configure.ac
   ===================================================================
   RCS file: /cvs/src/src/gdb/gdbserver/configure.ac,v
   retrieving revision 1.2
   diff -u -p -r1.2 configure.ac
   --- configure.ac	24 Feb 2005 20:26:32 -0000	1.2
   +++ configure.ac	13 Jun 2005 01:57:11 -0000
   @@ -40,10 +40,16 @@ AC_CHECK_HEADERS(sgtty.h termio.h termio

    BFD_NEED_DECLARATION(strerror)

   +AC_CHECK_TYPE(socklen_t,
   +	      [AC_DEFINE(HAVE_SOCKLEN_T, 1, [Define if you have socklen_t.])],
   +	      [], [#include <sys/socket.h>])

1. That AC_DEFINE is superfluous.  AC_CHECK_TYPE does that for you ;-).

2. On OpenBSD (and possibly other BSD-like systems) you'll need to
   #include <sys/types.h> to get socklen_t.

I propose to replace the above with what I just committed to gdb's
configure.ac:

AC_CHECK_TYPES(socklen_t, [], [],
[#include <sys/types.h>
#include <sys/socket.h>
])

Mark