* [COMMIT]: Follow-up ia64 patch for --without-libunwind
@ 2005-06-10 1:15 jjohnstn
2005-06-10 3:46 ` Daniel Jacobowitz
0 siblings, 1 reply; 3+ messages in thread
From: jjohnstn @ 2005-06-10 1:15 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: TEXT/PLAIN, Size: 916 bytes --]
The following patch fixes the problem with building the latest
ia64-tdep.c with --without-libunwind configured. It also removes
warnings about gdb_byte vs void *.
2005-06-09 Jeff Johnston <jjohnstn@redhat.com>
* ia64-tdep.c (ia64_pseudo_register_read): Use gdb_byte and
protect libunwind references with HAVE_LIBUNWIND_IA64_H flag.
* (ia64_pseudo_register_write): Use gdb_byte to remove warning.
* (ia64_register_to_value, ia64_value_to_register): Ditto.
* (ia64_frame_prev_register): Ditto.
* (ia64_libunwind_frame_prev_register): Ditto.
* (ia64_sigtramp_frame_prev_register): Ditto.
* (ia64_libunwind_sigtramp_frame_prev_register): Ditto.
* (ia64_store_return_value): Ditto.
[-- Attachment #2: Type: TEXT/PLAIN, Size: 3725 bytes --]
Index: ia64-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/ia64-tdep.c,v
retrieving revision 1.133
diff -u -p -r1.133 ia64-tdep.c
--- ia64-tdep.c 8 Jun 2005 21:54:22 -0000 1.133
+++ ia64-tdep.c 10 Jun 2005 01:08:40 -0000
@@ -673,14 +673,16 @@ rse_address_add(CORE_ADDR addr, int nslo
static void
ia64_pseudo_register_read (struct gdbarch *gdbarch, struct regcache *regcache,
- int regnum, void *buf)
+ int regnum, gdb_byte *buf)
{
if (regnum >= V32_REGNUM && regnum <= V127_REGNUM)
{
+#ifdef HAVE_LIBUNWIND_IA64_H
/* First try and use the libunwind special reg accessor, otherwise fallback to
standard logic. */
if (!libunwind_is_initialized ()
|| libunwind_get_reg_special (gdbarch, regnum, buf) != 0)
+#endif
{
/* The fallback position is to assume that r32-r127 are found sequentially
in memory starting at $bof. This isn't always true, but without libunwind,
@@ -791,7 +793,7 @@ ia64_pseudo_register_read (struct gdbarc
static void
ia64_pseudo_register_write (struct gdbarch *gdbarch, struct regcache *regcache,
- int regnum, const void *buf)
+ int regnum, const gdb_byte *buf)
{
if (regnum >= V32_REGNUM && regnum <= V127_REGNUM)
{
@@ -912,7 +914,7 @@ ia64_convert_register_p (int regno, stru
static void
ia64_register_to_value (struct frame_info *frame, int regnum,
- struct type *valtype, void *out)
+ struct type *valtype, gdb_byte *out)
{
char in[MAX_REGISTER_SIZE];
frame_register_read (frame, regnum, in);
@@ -921,7 +923,7 @@ ia64_register_to_value (struct frame_inf
static void
ia64_value_to_register (struct frame_info *frame, int regnum,
- struct type *valtype, const void *in)
+ struct type *valtype, const gdb_byte *in)
{
char out[MAX_REGISTER_SIZE];
convert_typed_floating (in, valtype, out, builtin_type_ia64_ext);
@@ -1576,7 +1578,7 @@ static void
ia64_frame_prev_register (struct frame_info *next_frame, void **this_cache,
int regnum, int *optimizedp,
enum lval_type *lvalp, CORE_ADDR *addrp,
- int *realnump, void *valuep)
+ int *realnump, gdb_byte *valuep)
{
struct ia64_frame_cache *cache =
ia64_frame_cache (next_frame, this_cache);
@@ -1976,7 +1978,7 @@ ia64_sigtramp_frame_prev_register (struc
void **this_cache,
int regnum, int *optimizedp,
enum lval_type *lvalp, CORE_ADDR *addrp,
- int *realnump, void *valuep)
+ int *realnump, gdb_byte *valuep)
{
char dummy_valp[MAX_REGISTER_SIZE];
char buf[MAX_REGISTER_SIZE];
@@ -2747,7 +2749,7 @@ ia64_libunwind_frame_prev_register (stru
void **this_cache,
int regnum, int *optimizedp,
enum lval_type *lvalp, CORE_ADDR *addrp,
- int *realnump, void *valuep)
+ int *realnump, gdb_byte *valuep)
{
int reg = regnum;
@@ -2885,7 +2887,7 @@ ia64_libunwind_sigtramp_frame_prev_regis
void **this_cache,
int regnum, int *optimizedp,
enum lval_type *lvalp, CORE_ADDR *addrp,
- int *realnump, void *valuep)
+ int *realnump, gdb_byte *valuep)
{
CORE_ADDR prev_ip, addr;
@@ -3497,7 +3499,8 @@ ia64_unwind_pc (struct gdbarch *gdbarch,
}
static void
-ia64_store_return_value (struct type *type, struct regcache *regcache, const void *valbuf)
+ia64_store_return_value (struct type *type, struct regcache *regcache,
+ const gdb_byte *valbuf)
{
if (TYPE_CODE (type) == TYPE_CODE_FLT)
{
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [COMMIT]: Follow-up ia64 patch for --without-libunwind
2005-06-10 1:15 [COMMIT]: Follow-up ia64 patch for --without-libunwind jjohnstn
@ 2005-06-10 3:46 ` Daniel Jacobowitz
2005-06-10 15:32 ` Jeff Johnston
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Jacobowitz @ 2005-06-10 3:46 UTC (permalink / raw)
To: jjohnstn; +Cc: gdb-patches
On Thu, Jun 09, 2005 at 09:15:31PM -0400, jjohnstn wrote:
> The following patch fixes the problem with building the latest
> ia64-tdep.c with --without-libunwind configured. It also removes
> warnings about gdb_byte vs void *.
>
> 2005-06-09 Jeff Johnston <jjohnstn@redhat.com>
>
> * ia64-tdep.c (ia64_pseudo_register_read): Use gdb_byte and
> protect libunwind references with HAVE_LIBUNWIND_IA64_H flag.
> * (ia64_pseudo_register_write): Use gdb_byte to remove warning.
> * (ia64_register_to_value, ia64_value_to_register): Ditto.
> * (ia64_frame_prev_register): Ditto.
> * (ia64_libunwind_frame_prev_register): Ditto.
> * (ia64_sigtramp_frame_prev_register): Ditto.
> * (ia64_libunwind_sigtramp_frame_prev_register): Ditto.
> * (ia64_store_return_value): Ditto.
Please fix the formatting - all but the first leading "*" are
unnecessary.
--
Daniel Jacobowitz
CodeSourcery, LLC
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [COMMIT]: Follow-up ia64 patch for --without-libunwind
2005-06-10 3:46 ` Daniel Jacobowitz
@ 2005-06-10 15:32 ` Jeff Johnston
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Johnston @ 2005-06-10 15:32 UTC (permalink / raw)
To: Daniel Jacobowitz; +Cc: gdb-patches
Daniel Jacobowitz wrote:
> On Thu, Jun 09, 2005 at 09:15:31PM -0400, jjohnstn wrote:
>
>>The following patch fixes the problem with building the latest
>>ia64-tdep.c with --without-libunwind configured. It also removes
>>warnings about gdb_byte vs void *.
>>
>>2005-06-09 Jeff Johnston <jjohnstn@redhat.com>
>>
>> * ia64-tdep.c (ia64_pseudo_register_read): Use gdb_byte and
>> protect libunwind references with HAVE_LIBUNWIND_IA64_H flag.
>> * (ia64_pseudo_register_write): Use gdb_byte to remove warning.
>> * (ia64_register_to_value, ia64_value_to_register): Ditto.
>> * (ia64_frame_prev_register): Ditto.
>> * (ia64_libunwind_frame_prev_register): Ditto.
>> * (ia64_sigtramp_frame_prev_register): Ditto.
>> * (ia64_libunwind_sigtramp_frame_prev_register): Ditto.
>> * (ia64_store_return_value): Ditto.
>
>
> Please fix the formatting - all but the first leading "*" are
> unnecessary.
>
>
D'oh. I've done enough ChangeLog entries to know that. Total brain freeze. :(
Fixed.
-- Jeff J.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-06-10 15:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-06-10 1:15 [COMMIT]: Follow-up ia64 patch for --without-libunwind jjohnstn
2005-06-10 3:46 ` Daniel Jacobowitz
2005-06-10 15:32 ` Jeff Johnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox