From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27410 invoked by alias); 10 Jun 2005 15:32:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27395 invoked by uid 22791); 10 Jun 2005 15:32:01 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 10 Jun 2005 15:32:01 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j5AFVxC4014250 for ; Fri, 10 Jun 2005 11:31:59 -0400 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j5AFVxO16515; Fri, 10 Jun 2005 11:31:59 -0400 Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.toronto.redhat.com [172.16.14.9]) by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id j5AFVvMX022988; Fri, 10 Jun 2005 11:31:59 -0400 Received: from [172.16.14.72] (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id F0C2C800108; Fri, 10 Jun 2005 11:31:56 -0400 (EDT) Message-ID: <42A9B26C.7040407@redhat.com> Date: Fri, 10 Jun 2005 15:32:00 -0000 From: Jeff Johnston User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040805 Netscape/7.2 MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [COMMIT]: Follow-up ia64 patch for --without-libunwind References: <20050610034652.GA23889@nevyn.them.org> In-Reply-To: <20050610034652.GA23889@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-06/txt/msg00094.txt.bz2 Daniel Jacobowitz wrote: > On Thu, Jun 09, 2005 at 09:15:31PM -0400, jjohnstn wrote: > >>The following patch fixes the problem with building the latest >>ia64-tdep.c with --without-libunwind configured. It also removes >>warnings about gdb_byte vs void *. >> >>2005-06-09 Jeff Johnston >> >> * ia64-tdep.c (ia64_pseudo_register_read): Use gdb_byte and >> protect libunwind references with HAVE_LIBUNWIND_IA64_H flag. >> * (ia64_pseudo_register_write): Use gdb_byte to remove warning. >> * (ia64_register_to_value, ia64_value_to_register): Ditto. >> * (ia64_frame_prev_register): Ditto. >> * (ia64_libunwind_frame_prev_register): Ditto. >> * (ia64_sigtramp_frame_prev_register): Ditto. >> * (ia64_libunwind_sigtramp_frame_prev_register): Ditto. >> * (ia64_store_return_value): Ditto. > > > Please fix the formatting - all but the first leading "*" are > unnecessary. > > D'oh. I've done enough ChangeLog entries to know that. Total brain freeze. :( Fixed. -- Jeff J.