From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC/RFA] Set current language when dumping symtab
Date: Wed, 01 Jun 2005 02:00:00 -0000 [thread overview]
Message-ID: <20050601015952.GA3774@nevyn.them.org> (raw)
In-Reply-To: <20050601012932.GK2014@adacore.com>
On Tue, May 31, 2005 at 06:29:32PM -0700, Joel Brobecker wrote:
> > and there's no reason not to fold this into dump_symtab.
>
> I tend to still prefer the folding, because I find it clearer
> that way. And if for any reason we change the implementation of
> dump_symtab_1 to have an early return somewhere in the code, we're
> not in danger of forgetting to reset the language.
>
> But I'm happy either way. Let me know which you prefer, and I'll
> submit a new patch.
OK - you have a good reason, that's enough for me :-)
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-06-01 2:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-04 0:20 Joel Brobecker
2005-05-29 0:09 ` Daniel Jacobowitz
2005-05-29 2:54 ` Joel Brobecker
2005-05-29 2:57 ` Daniel Jacobowitz
2005-05-30 15:59 ` Joel Brobecker
2005-05-30 19:55 ` Joel Brobecker
2005-05-30 20:06 ` Daniel Jacobowitz
2005-06-01 1:29 ` Joel Brobecker
2005-06-01 2:00 ` Daniel Jacobowitz [this message]
2005-06-03 0:10 ` Joel Brobecker
2005-06-03 19:14 ` Daniel Jacobowitz
2005-06-03 23:27 ` Joel Brobecker
2005-06-02 16:54 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050601015952.GA3774@nevyn.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox