From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15526 invoked by alias); 1 Jun 2005 02:00:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15154 invoked by uid 22791); 1 Jun 2005 01:59:54 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 01 Jun 2005 01:59:54 +0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DdIWO-0000zp-2V; Tue, 31 May 2005 21:59:52 -0400 Date: Wed, 01 Jun 2005 02:00:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC/RFA] Set current language when dumping symtab Message-ID: <20050601015952.GA3774@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sources.redhat.com References: <20050504001955.GE2439@adacore.com> <20050528234905.GF22435@nevyn.them.org> <20050529021056.GF18754@adacore.com> <20050529025401.GA14380@nevyn.them.org> <20050530054538.GM18754@adacore.com> <20050530195338.GO18754@adacore.com> <20050530195458.GB31201@nevyn.them.org> <20050601012932.GK2014@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050601012932.GK2014@adacore.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-06/txt/msg00002.txt.bz2 On Tue, May 31, 2005 at 06:29:32PM -0700, Joel Brobecker wrote: > > and there's no reason not to fold this into dump_symtab. > > I tend to still prefer the folding, because I find it clearer > that way. And if for any reason we change the implementation of > dump_symtab_1 to have an early return somewhere in the code, we're > not in danger of forgetting to reset the language. > > But I'm happy either way. Let me know which you prefer, and I'll > submit a new patch. OK - you have a good reason, that's enough for me :-) -- Daniel Jacobowitz CodeSourcery, LLC