Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFC/RFA] Set current language when dumping symtab
Date: Fri, 03 Jun 2005 00:10:00 -0000	[thread overview]
Message-ID: <20050603001007.GC960@adacore.com> (raw)
In-Reply-To: <20050601015952.GA3774@nevyn.them.org>

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

> OK - you have a good reason, that's enough for me :-)

Cool :-). Here is the patch after removing the unused variable.

2005-06-02  Joel Brobecker  <brobecker@adacore.com>

        * symmisc.c (dump_symtab_1): Renamed from dump_symtab.
        (dump_symtab): New function.

Tested on x86-linux. OK to apply?

Thanks,
-- 
Joel

[-- Attachment #2: symmisc.c.diff --]
[-- Type: text/plain, Size: 1213 bytes --]

Index: symmisc.c
===================================================================
RCS file: /cvs/src/src/gdb/symmisc.c,v
retrieving revision 1.38
diff -u -p -r1.38 symmisc.c
--- symmisc.c	14 Feb 2005 14:37:38 -0000	1.38
+++ symmisc.c	2 Jun 2005 16:57:53 -0000
@@ -440,8 +440,8 @@ dump_psymtab (struct objfile *objfile, s
 }
 
 static void
-dump_symtab (struct objfile *objfile, struct symtab *symtab,
-	     struct ui_file *outfile)
+dump_symtab_1 (struct objfile *objfile, struct symtab *symtab,
+	       struct ui_file *outfile)
 {
   int i;
   struct dict_iterator iter;
@@ -533,6 +533,22 @@ dump_symtab (struct objfile *objfile, st
     }
 }
 
+static void
+dump_symtab (struct objfile *objfile, struct symtab *symtab,
+	     struct ui_file *outfile)
+{
+  enum language saved_lang;
+
+  /* Set the current language to the language of the symtab we're dumping
+     because certain routines used during dump_symtab() use the current
+     language to print an image of the symbol.  We'll restore it later.  */
+  saved_lang = set_language (symtab->language);
+
+  dump_symtab_1 (objfile, symtab, outfile);
+
+  set_language (saved_lang);
+}
+
 void
 maintenance_print_symbols (char *args, int from_tty)
 {

  reply	other threads:[~2005-06-03  0:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-04  0:20 Joel Brobecker
2005-05-29  0:09 ` Daniel Jacobowitz
2005-05-29  2:54   ` Joel Brobecker
2005-05-29  2:57     ` Daniel Jacobowitz
2005-05-30 15:59       ` Joel Brobecker
2005-05-30 19:55         ` Joel Brobecker
2005-05-30 20:06           ` Daniel Jacobowitz
2005-06-01  1:29             ` Joel Brobecker
2005-06-01  2:00               ` Daniel Jacobowitz
2005-06-03  0:10                 ` Joel Brobecker [this message]
2005-06-03 19:14                   ` Daniel Jacobowitz
2005-06-03 23:27                     ` Joel Brobecker
2005-06-02 16:54         ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050603001007.GC960@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox