Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Richard Henderson <rth@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Question: Checking register value in buffer
Date: Thu, 19 May 2005 03:23:00 -0000	[thread overview]
Message-ID: <20050519030349.GA8255@redhat.com> (raw)
In-Reply-To: <20050519024857.GY12565@adacore.com>

On Thu, May 19, 2005 at 12:48:57PM +1000, Joel Brobecker wrote:
> In terms of computing the mask, I'm thinking of using something
> like this:
> 
>   sign_mask = 1 << (sizeof (rav) * TARGET_CHAR_BIT - 1);

This confuses host and target notions.  You would have wanted
the *host* CHAR_BIT, since you're using the host sizeof.

>   zero_mask = sign_mask ^ -1;

This fails if rav is *wider* than 64-bits.

> Are there better ways of computing these masks?

How about just 

  sign = (LONGEST)1 << 63
  zero = sign - 1;



r~


  reply	other threads:[~2005-05-19  3:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-19  2:49 Joel Brobecker
2005-05-19  3:03 ` Richard Henderson
2005-05-19  3:07   ` Joel Brobecker
2005-05-19  3:23     ` Richard Henderson [this message]
2005-05-19  3:33       ` Joel Brobecker
2005-05-19  4:52         ` Richard Henderson
2005-05-19  5:37         ` Daniel Jacobowitz
2005-05-19  3:26   ` Daniel Jacobowitz
2005-05-19 16:41 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050519030349.GA8255@redhat.com \
    --to=rth@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox