From: Joel Brobecker <brobecker@adacore.com>
To: Richard Henderson <rth@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Question: Checking register value in buffer
Date: Thu, 19 May 2005 03:07:00 -0000 [thread overview]
Message-ID: <20050519024857.GY12565@adacore.com> (raw)
In-Reply-To: <20050519022256.GA8204@redhat.com>
> On Thu, May 19, 2005 at 12:04:44PM +1000, Joel Brobecker wrote:
> > LONGEST rav = extract_signed_integer (buf, 8)
> >
> > and then do the test using integer arithmetics. But then I'm not guarantied
> > that LONGEST is at least 64bit long, am I.
>
> It had better be, or the rest of alpha_next_pc is broken too.
>
> Since it isn't, or isn't reported to be, you might as well
> assume it is large enough.
Ah yes, of course.
In terms of computing the mask, I'm thinking of using something
like this:
sign_mask = 1 << (sizeof (rav) * TARGET_CHAR_BIT - 1);
zero_mask = sign_mask ^ -1;
Are there better ways of computing these masks?
> > How are these sort of checks usually done in GDB?
>
> In gcc-land we have a "need_64bit_hwint" bit in config.gcc, and it
> is set for targets that require the equivalent of LONGEST be at
> least 64 bits, or we error out of configure.
>
> Dunno what's done in gdb.
I just noticed in extract_signed_integer() that we actually do a size
check before doing the extraction, so we would get an error if LONGEST
was not large enough.
Thanks,
--
Joel
next prev parent reply other threads:[~2005-05-19 2:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-19 2:49 Joel Brobecker
2005-05-19 3:03 ` Richard Henderson
2005-05-19 3:07 ` Joel Brobecker [this message]
2005-05-19 3:23 ` Richard Henderson
2005-05-19 3:33 ` Joel Brobecker
2005-05-19 4:52 ` Richard Henderson
2005-05-19 5:37 ` Daniel Jacobowitz
2005-05-19 3:26 ` Daniel Jacobowitz
2005-05-19 16:41 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050519024857.GY12565@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox