From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sources.redhat.com, gdb-patches@sourceware.org
Subject: Re: [COMMIT] Avoid compiler warnings in gnu-v3-abi.c
Date: Thu, 12 May 2005 20:51:00 -0000 [thread overview]
Message-ID: <20050512205004.GA13519@nevyn.them.org> (raw)
In-Reply-To: <01c55733$Blat.v2.4$9ceaa860@zahav.net.il>
On Thu, May 12, 2005 at 11:45:01PM +0300, Eli Zaretskii wrote:
> > Date: Thu, 12 May 2005 11:33:41 -0400
> > From: Daniel Jacobowitz <drow@false.org>
> >
> > What compiler version produced this warning? GCC 3.3 and 3.4 don't,
> > AFAICT; maybe it's new in 4.0.
>
> I used GCC 3.4.3. Perhaps it's a matter of what warning options are
> turned on? The ones I used are in the current CVS's djconfig.sh.
>
> Are you saying that this is a GCC bug? I don't think so, since the
> code is clearly unclean: it mixes two different enums. GCC is right
> warning about that.
Yes, the patch is definitely right. I hadn't thought that GCC 3.4.3
generated the warning, but I only checked 3.3.
--
Daniel Jacobowitz
CodeSourcery, LLC
WARNING: multiple messages have this Message-ID
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sources.redhat.com, gdb-patches@sourceware.org
Subject: Re: [COMMIT] Avoid compiler warnings in gnu-v3-abi.c
Date: Thu, 12 May 2005 20:55:00 -0000 [thread overview]
Message-ID: <20050512205004.GA13519@nevyn.them.org> (raw)
Message-ID: <20050512205500.Mn6TCZxm3I3h21WUxqk-NlJfRa-UIdwhmsSpWqH-W-A@z> (raw)
In-Reply-To: <01c55733$Blat.v2.4$9ceaa860@zahav.net.il>
On Thu, May 12, 2005 at 11:45:01PM +0300, Eli Zaretskii wrote:
> > Date: Thu, 12 May 2005 11:33:41 -0400
> > From: Daniel Jacobowitz <drow@false.org>
> >
> > What compiler version produced this warning? GCC 3.3 and 3.4 don't,
> > AFAICT; maybe it's new in 4.0.
>
> I used GCC 3.4.3. Perhaps it's a matter of what warning options are
> turned on? The ones I used are in the current CVS's djconfig.sh.
>
> Are you saying that this is a GCC bug? I don't think so, since the
> code is clearly unclean: it mixes two different enums. GCC is right
> warning about that.
Yes, the patch is definitely right. I hadn't thought that GCC 3.4.3
generated the warning, but I only checked 3.3.
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-05-12 20:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-12 15:33 Eli Zaretskii
2005-05-12 15:42 ` Daniel Jacobowitz
2005-05-12 20:50 ` Eli Zaretskii
2005-05-12 20:51 ` Daniel Jacobowitz [this message]
2005-05-12 20:55 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050512205004.GA13519@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox