From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1437 invoked by alias); 12 May 2005 20:50:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1405 invoked from network); 12 May 2005 20:50:04 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 12 May 2005 20:50:04 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DWKdA-0003WL-Bf; Thu, 12 May 2005 16:50:04 -0400 Date: Thu, 12 May 2005 20:51:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com, gdb-patches@sourceware.org Subject: Re: [COMMIT] Avoid compiler warnings in gnu-v3-abi.c Message-ID: <20050512205004.GA13519@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com, gdb-patches@sourceware.org References: <01c55707$Blat.v2.4$809d30a0@zahav.net.il> <20050512153340.GA3028@nevyn.them.org> <01c55733$Blat.v2.4$9ceaa860@zahav.net.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01c55733$Blat.v2.4$9ceaa860@zahav.net.il> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00307.txt.bz2 On Thu, May 12, 2005 at 11:45:01PM +0300, Eli Zaretskii wrote: > > Date: Thu, 12 May 2005 11:33:41 -0400 > > From: Daniel Jacobowitz > > > > What compiler version produced this warning? GCC 3.3 and 3.4 don't, > > AFAICT; maybe it's new in 4.0. > > I used GCC 3.4.3. Perhaps it's a matter of what warning options are > turned on? The ones I used are in the current CVS's djconfig.sh. > > Are you saying that this is a GCC bug? I don't think so, since the > code is clearly unclean: it mixes two different enums. GCC is right > warning about that. Yes, the patch is definitely right. I hadn't thought that GCC 3.4.3 generated the warning, but I only checked 3.3. -- Daniel Jacobowitz CodeSourcery, LLC From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1468 invoked by alias); 12 May 2005 20:50:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1404 invoked from network); 12 May 2005 20:50:04 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 12 May 2005 20:50:04 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DWKdA-0003WL-Bf; Thu, 12 May 2005 16:50:04 -0400 Date: Thu, 12 May 2005 20:55:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com, gdb-patches@sourceware.org Subject: Re: [COMMIT] Avoid compiler warnings in gnu-v3-abi.c Message-ID: <20050512205004.GA13519@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com, gdb-patches@sourceware.org References: <01c55707$Blat.v2.4$809d30a0@zahav.net.il> <20050512153340.GA3028@nevyn.them.org> <01c55733$Blat.v2.4$9ceaa860@zahav.net.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01c55733$Blat.v2.4$9ceaa860@zahav.net.il> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00308.txt.bz2 Message-ID: <20050512205500.Mn6TCZxm3I3h21WUxqk-NlJfRa-UIdwhmsSpWqH-W-A@z> On Thu, May 12, 2005 at 11:45:01PM +0300, Eli Zaretskii wrote: > > Date: Thu, 12 May 2005 11:33:41 -0400 > > From: Daniel Jacobowitz > > > > What compiler version produced this warning? GCC 3.3 and 3.4 don't, > > AFAICT; maybe it's new in 4.0. > > I used GCC 3.4.3. Perhaps it's a matter of what warning options are > turned on? The ones I used are in the current CVS's djconfig.sh. > > Are you saying that this is a GCC bug? I don't think so, since the > code is clearly unclean: it mixes two different enums. GCC is right > warning about that. Yes, the patch is definitely right. I hadn't thought that GCC 3.4.3 generated the warning, but I only checked 3.3. -- Daniel Jacobowitz CodeSourcery, LLC