From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sources.redhat.com
Subject: Re: fullname syntax variable for testsuite
Date: Thu, 05 May 2005 17:39:00 -0000 [thread overview]
Message-ID: <20050505173942.GA17561@nevyn.them.org> (raw)
In-Reply-To: <20050505173202.GC31758@white>
On Thu, May 05, 2005 at 01:32:02PM -0400, Bob Rossi wrote:
> Hi all,
>
> Hopefully this should make everyone happy. If the regex is slightly
> incorrect, after this patch, it should be simple to modify it and have
> the testsuite pick up on those changes.
>
> As you will notice, the initial regex that Eli posted does not match the
> case d:foo. If it is desired to match this case up front, I can do that.
> Otherwise, it's noted in the comment, and can be changed when we run
> into the problem.
For Windows, don't you want the more specific version Chris posted?
[a-zA-Z]:\\.*\|\\\\[^\\][^\\]*\\[^\\].*
Also, while I don't want to quibble about the regex more than necessary
right now, it should match the final slash in the path. Either /.*/ or
\.*\ as the case may be.
> +# The variable fullname_syntax is a regexp which matches what GDB considers
> +# an absolute path. It is currently debatable if the windows style paths
> +# d:foo and \abc should be considered valid as an absolute path.
> +# This regex matches \abc but not d:foo.
> +global fullname_syntax
> +if ![info exists fullname_syntax] then {
> + set fullname_syntax "(\[A-z\]:)?\[/\\\\\].*"
> +}
Don't bother with the 'info exists' unless there's some need for it
that I'm missing. Please capitalize Windows.
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-05-05 17:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-05 17:32 Bob Rossi
2005-05-05 17:39 ` Daniel Jacobowitz [this message]
2005-05-06 0:44 ` Bob Rossi
2005-05-06 1:54 ` Daniel Jacobowitz
2005-05-07 3:13 ` Bob Rossi
2005-05-08 13:43 ` Bob Rossi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050505173942.GA17561@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox