Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Bob Rossi <bob@brasko.net>
To: gdb-patches@sources.redhat.com
Subject: Re: fullname syntax variable for testsuite
Date: Sun, 08 May 2005 13:43:00 -0000	[thread overview]
Message-ID: <20050508134225.GA6099@white> (raw)
In-Reply-To: <20050507031258.GA4274@white>

On Fri, May 06, 2005 at 11:12:58PM -0400, Bob Rossi wrote:
> On Thu, May 05, 2005 at 09:54:42PM -0400, Daniel Jacobowitz wrote:
> > On Thu, May 05, 2005 at 08:44:15PM -0400, Bob Rossi wrote:
> > > Here is the updated patch. I broke down the regexp into several cases.
> > > It should be very easy to maintain (add/remove) the regexp as time goes
> > > on. If there are any other modifications that need to be made, please
> > > let me know.
> > > 
> > > Thanks,
> > > Bob Rossi
> > > 
> > > 
> > > 2005-05-05  Bob Rossi  <bob_rossi@cox.net>
> > > 
> > >     * lib/gdb.exp (fullname_syntax): Added global regex.
> > >     (fullname_syntax_POSIX): Ditto.
> > >     (fullname_syntax_UNC): Ditto.
> > >     (fullname_syntax_DOS_CASE): Ditto.
> > >     (fullname_syntax_DOS): Ditto.
> > >     * gdb.mi/mi-file.exp (test_file_list_exec_source_file): Added
> > >     fullname_syntax variable to scope and use it.
> > >     (test_file_list_exec_source_files): Ditto.
> > >     * gdb.mi/mi2-file.exp (test_file_list_exec_source_file): Ditto.
> > 
> > This patch is OK with me.  Please wait a day to see if anyone else has
> > comments, and then you can check this in.  After you do that I'll
> > revise Dennis's patch.
> 
> I changed the DOS_CASE 
>    from set fullname_syntax_DOS_CASE {\\[^\\]+\\}
>    to set fullname_syntax_DOS_CASE {\\[^\\].*\\}
> as Dennis noticed, it didn't match the regex
>     \a\b\c\d\basics.c
> 
> Anyways, please consider this as a last chance to speak up with any
> problems. Otherwise, I'll commit tomorrow.

Committed.

Bob Rossi


      reply	other threads:[~2005-05-08 13:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-05 17:32 Bob Rossi
2005-05-05 17:39 ` Daniel Jacobowitz
2005-05-06  0:44   ` Bob Rossi
2005-05-06  1:54     ` Daniel Jacobowitz
2005-05-07  3:13       ` Bob Rossi
2005-05-08 13:43         ` Bob Rossi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050508134225.GA6099@white \
    --to=bob@brasko.net \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox