From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5633 invoked by alias); 5 May 2005 17:39:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5488 invoked from network); 5 May 2005 17:39:42 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 5 May 2005 17:39:42 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DTkK6-0004cy-JE for ; Thu, 05 May 2005 13:39:42 -0400 Date: Thu, 05 May 2005 17:39:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: fullname syntax variable for testsuite Message-ID: <20050505173942.GA17561@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20050505173202.GC31758@white> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050505173202.GC31758@white> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00172.txt.bz2 On Thu, May 05, 2005 at 01:32:02PM -0400, Bob Rossi wrote: > Hi all, > > Hopefully this should make everyone happy. If the regex is slightly > incorrect, after this patch, it should be simple to modify it and have > the testsuite pick up on those changes. > > As you will notice, the initial regex that Eli posted does not match the > case d:foo. If it is desired to match this case up front, I can do that. > Otherwise, it's noted in the comment, and can be changed when we run > into the problem. For Windows, don't you want the more specific version Chris posted? [a-zA-Z]:\\.*\|\\\\[^\\][^\\]*\\[^\\].* Also, while I don't want to quibble about the regex more than necessary right now, it should match the final slash in the path. Either /.*/ or \.*\ as the case may be. > +# The variable fullname_syntax is a regexp which matches what GDB considers > +# an absolute path. It is currently debatable if the windows style paths > +# d:foo and \abc should be considered valid as an absolute path. > +# This regex matches \abc but not d:foo. > +global fullname_syntax > +if ![info exists fullname_syntax] then { > + set fullname_syntax "(\[A-z\]:)?\[/\\\\\].*" > +} Don't bother with the 'info exists' unless there's some need for it that I'm missing. Please capitalize Windows. -- Daniel Jacobowitz CodeSourcery, LLC