From: Christopher Faylor <me@cgf.cx>
To: gdb-patches@sources.redhat.com, Paul Brook <paul@codesourcery.com>
Subject: Re: [patch] Crash on windows hosts
Date: Thu, 28 Apr 2005 14:05:00 -0000 [thread overview]
Message-ID: <20050428140231.GC24351@trixie.casa.cgf.cx> (raw)
In-Reply-To: <20050428132149.GA29911@nevyn.them.org>
On Thu, Apr 28, 2005 at 09:21:49AM -0400, Daniel Jacobowitz wrote:
>On Wed, Apr 27, 2005 at 11:36:12PM -0400, Christopher Faylor wrote:
>> I didn't look closely to see why Windows would return a NULL when other
>> systems would not but given that it is obviously possible for
>> serial_fdopen to return NULL, it seems like this patch is correct.
>
>I presume the reason is because there's no serial port named
>"hardwire" on Windows - only Unix-like systems and GO32 (DOS).
So, that points out a generic problem lurking behind this one. The
Windows part of gdb should implement a "hardwire" serial port. I guess
I'll put that on my todo list.
Btw, there is one other use of serial_fdopen which uses NULL protection
so, again, I'd say this is a trivial fix which should be checked in.
cgf
prev parent reply other threads:[~2005-04-28 14:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-28 2:00 Paul Brook
2005-04-28 3:27 ` Daniel Jacobowitz
2005-04-28 3:36 ` Christopher Faylor
2005-04-28 13:22 ` Daniel Jacobowitz
2005-04-28 14:05 ` Christopher Faylor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050428140231.GC24351@trixie.casa.cgf.cx \
--to=me@cgf.cx \
--cc=gdb-patches@sources.redhat.com \
--cc=paul@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox