From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3638 invoked by alias); 28 Apr 2005 14:05:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 875 invoked from network); 28 Apr 2005 14:02:32 -0000 Received: from unknown (HELO cgf.cx) (66.30.17.189) by sourceware.org with SMTP; 28 Apr 2005 14:02:32 -0000 Received: by cgf.cx (Postfix, from userid 201) id 8CDD713C1C8; Thu, 28 Apr 2005 10:02:31 -0400 (EDT) Date: Thu, 28 Apr 2005 14:05:00 -0000 From: Christopher Faylor To: gdb-patches@sources.redhat.com, Paul Brook Subject: Re: [patch] Crash on windows hosts Message-ID: <20050428140231.GC24351@trixie.casa.cgf.cx> Mail-Followup-To: gdb-patches@sources.redhat.com, Paul Brook References: <200504280300.34690.paul@codesourcery.com> <20050428032721.GA6898@nevyn.them.org> <20050428033612.GC32594@trixie.casa.cgf.cx> <20050428132149.GA29911@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050428132149.GA29911@nevyn.them.org> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00388.txt.bz2 On Thu, Apr 28, 2005 at 09:21:49AM -0400, Daniel Jacobowitz wrote: >On Wed, Apr 27, 2005 at 11:36:12PM -0400, Christopher Faylor wrote: >> I didn't look closely to see why Windows would return a NULL when other >> systems would not but given that it is obviously possible for >> serial_fdopen to return NULL, it seems like this patch is correct. > >I presume the reason is because there's no serial port named >"hardwire" on Windows - only Unix-like systems and GO32 (DOS). So, that points out a generic problem lurking behind this one. The Windows part of gdb should implement a "hardwire" serial port. I guess I'll put that on my todo list. Btw, there is one other use of serial_fdopen which uses NULL protection so, again, I'd say this is a trivial fix which should be checked in. cgf