From: Christopher Faylor <me@cgf.cx>
To: Paul Brook <paul@codesourcery.com>, gdb-patches@sources.redhat.com
Subject: Re: [patch] Crash on windows hosts
Date: Thu, 28 Apr 2005 03:36:00 -0000 [thread overview]
Message-ID: <20050428033612.GC32594@trixie.casa.cgf.cx> (raw)
In-Reply-To: <20050428032721.GA6898@nevyn.them.org>
On Wed, Apr 27, 2005 at 11:27:21PM -0400, Daniel Jacobowitz wrote:
>On Thu, Apr 28, 2005 at 03:00:34AM +0100, Paul Brook wrote:
>> serial_fdopen can return NULL on non-unix (ie. windows) hosts. This was
>> causing a segfault in print_flush.
>> The attached patch fixes this.
>>
>> Ok?
>>
>> Paul
>>
>> 2005-04-28 Paul Brook <paul@codesourcery.com>
>>
>> * exceptions.c (print_flush): Handle NULL gdb_stdout_serial.
>
>Hmm, this is probably OK... yeah, should be safe. Give it a day in
>case anyone who knows more about Windows than I do wants to object. I
>can't think of any reason to do this; we've already called the stdio
>flush routines. At worst it'll be cosmetic.
I didn't look closely to see why Windows would return a NULL when other
systems would not but given that it is obviously possible for
serial_fdopen to return NULL, it seems like this patch is correct.
So, I'd agree with Daniel that it should be checked in.
cgf
next prev parent reply other threads:[~2005-04-28 3:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-28 2:00 Paul Brook
2005-04-28 3:27 ` Daniel Jacobowitz
2005-04-28 3:36 ` Christopher Faylor [this message]
2005-04-28 13:22 ` Daniel Jacobowitz
2005-04-28 14:05 ` Christopher Faylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050428033612.GC32594@trixie.casa.cgf.cx \
--to=me@cgf.cx \
--cc=gdb-patches@sources.redhat.com \
--cc=paul@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox