From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17075 invoked by alias); 28 Apr 2005 03:36:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16614 invoked from network); 28 Apr 2005 03:36:13 -0000 Received: from unknown (HELO cgf.cx) (66.30.17.189) by sourceware.org with SMTP; 28 Apr 2005 03:36:13 -0000 Received: by cgf.cx (Postfix, from userid 201) id F351E13C2C5; Wed, 27 Apr 2005 23:36:12 -0400 (EDT) Date: Thu, 28 Apr 2005 03:36:00 -0000 From: Christopher Faylor To: Paul Brook , gdb-patches@sources.redhat.com Subject: Re: [patch] Crash on windows hosts Message-ID: <20050428033612.GC32594@trixie.casa.cgf.cx> Mail-Followup-To: Paul Brook , gdb-patches@sources.redhat.com References: <200504280300.34690.paul@codesourcery.com> <20050428032721.GA6898@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050428032721.GA6898@nevyn.them.org> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00382.txt.bz2 On Wed, Apr 27, 2005 at 11:27:21PM -0400, Daniel Jacobowitz wrote: >On Thu, Apr 28, 2005 at 03:00:34AM +0100, Paul Brook wrote: >> serial_fdopen can return NULL on non-unix (ie. windows) hosts. This was >> causing a segfault in print_flush. >> The attached patch fixes this. >> >> Ok? >> >> Paul >> >> 2005-04-28 Paul Brook >> >> * exceptions.c (print_flush): Handle NULL gdb_stdout_serial. > >Hmm, this is probably OK... yeah, should be safe. Give it a day in >case anyone who knows more about Windows than I do wants to object. I >can't think of any reason to do this; we've already called the stdio >flush routines. At worst it'll be cosmetic. I didn't look closely to see why Windows would return a NULL when other systems would not but given that it is obviously possible for serial_fdopen to return NULL, it seems like this patch is correct. So, I'd agree with Daniel that it should be checked in. cgf