Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: eliz@gnu.org
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Fix file name generation in edit_command (was: Ver 6.3 edit command failing)
Date: Wed, 27 Apr 2005 17:43:00 -0000	[thread overview]
Message-ID: <200504271742.j3RHgpB5019802@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <01c54b40$Blat.v2.4$be3bafe0@zahav.net.il> (eliz@gnu.org)

   Date: Wed, 27 Apr 2005 18:48:46 +0300
   From: "Eli Zaretskii" <eliz@gnu.org>

   Thanks for the tip.  Here's the revised patch:

   2005-04-27  Eli Zaretskii  <eliz@gnu.org>

	   * cli/cli-cmds.c (edit_command): If symtab->fullname is not yet
	   set, use symtab_to_fullname , instead of trying to do its job.

And you get extra bonus points for eliminating sprintf(3) ;-)

Is it just me, or do others also find the NULL == expression bits a
bit odd?  Anyway, they're not your fault, although I'd welcome you ti
fix those ;-).

Mark


  reply	other threads:[~2005-04-27 17:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1DLM3u-0000IQ-Vj@lists.gnu.org>
2005-04-27 14:32 ` Eli Zaretskii
2005-04-27 14:36   ` Daniel Jacobowitz
2005-04-27 15:52     ` Eli Zaretskii
2005-04-27 17:43       ` Mark Kettenis [this message]
2005-04-28  7:10         ` Eli Zaretskii
2005-04-27 18:04       ` Daniel Jacobowitz
2005-04-28  7:05         ` Eli Zaretskii
2005-04-28 20:39         ` Eli Zaretskii
2005-04-28 20:42           ` Daniel Jacobowitz
2005-04-28 21:04             ` Eli Zaretskii
2005-04-28 21:18               ` Daniel Jacobowitz
2005-04-29  7:07                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200504271742.j3RHgpB5019802@elgar.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox