From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15526 invoked by alias); 27 Apr 2005 17:43:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15212 invoked from network); 27 Apr 2005 17:43:07 -0000 Received: from unknown (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org with SMTP; 27 Apr 2005 17:43:07 -0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j3RHgu0H016219; Wed, 27 Apr 2005 19:42:56 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j3RHgtKW022167; Wed, 27 Apr 2005 19:42:55 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j3RHgpB5019802; Wed, 27 Apr 2005 19:42:51 +0200 (CEST) Date: Wed, 27 Apr 2005 17:43:00 -0000 Message-Id: <200504271742.j3RHgpB5019802@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: eliz@gnu.org CC: gdb-patches@sources.redhat.com In-reply-to: <01c54b40$Blat.v2.4$be3bafe0@zahav.net.il> (eliz@gnu.org) Subject: Re: [RFA] Fix file name generation in edit_command (was: Ver 6.3 edit command failing) References: <01c54b35$Blat.v2.4$c3f52520@zahav.net.il> <20050427143620.GA1686@nevyn.them.org> <01c54b40$Blat.v2.4$be3bafe0@zahav.net.il> X-SW-Source: 2005-04/txt/msg00369.txt.bz2 Date: Wed, 27 Apr 2005 18:48:46 +0300 From: "Eli Zaretskii" Thanks for the tip. Here's the revised patch: 2005-04-27 Eli Zaretskii * cli/cli-cmds.c (edit_command): If symtab->fullname is not yet set, use symtab_to_fullname , instead of trying to do its job. And you get extra bonus points for eliminating sprintf(3) ;-) Is it just me, or do others also find the NULL == expression bits a bit odd? Anyway, they're not your fault, although I'd welcome you ti fix those ;-). Mark