From: "Eli Zaretskii" <eliz@gnu.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Fix file name generation in edit_command (was: Ver 6.3 edit command failing)
Date: Thu, 28 Apr 2005 07:10:00 -0000 [thread overview]
Message-ID: <01c54bc1$Blat.v2.4$35ba4ba0@zahav.net.il> (raw)
In-Reply-To: <200504271742.j3RHgpB5019802@elgar.sibelius.xs4all.nl> (message from Mark Kettenis on Wed, 27 Apr 2005 19:42:51 +0200 (CEST))
> Date: Wed, 27 Apr 2005 19:42:51 +0200 (CEST)
> From: Mark Kettenis <mark.kettenis@xs4all.nl>
> CC: gdb-patches@sources.redhat.com
>
> Is it just me, or do others also find the NULL == expression bits a
> bit odd?
There's a school of thought that writing comparisons with a constant
like this prevent errors whereby one uses "=" instead of "==": any
reasonable compiler will yell bloody murder if you say "NULL = foo",
while "foo = NULL" might go unnoticed with some compilers.
However, it looks like the fragment I was patching is the only one
which uses this notation in the while cli directory, so perhaps it's
okay to swap the identifiers to the more traditional form.
next prev parent reply other threads:[~2005-04-28 7:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1DLM3u-0000IQ-Vj@lists.gnu.org>
2005-04-27 14:32 ` Eli Zaretskii
2005-04-27 14:36 ` Daniel Jacobowitz
2005-04-27 15:52 ` Eli Zaretskii
2005-04-27 17:43 ` Mark Kettenis
2005-04-28 7:10 ` Eli Zaretskii [this message]
2005-04-27 18:04 ` Daniel Jacobowitz
2005-04-28 7:05 ` Eli Zaretskii
2005-04-28 20:39 ` Eli Zaretskii
2005-04-28 20:42 ` Daniel Jacobowitz
2005-04-28 21:04 ` Eli Zaretskii
2005-04-28 21:18 ` Daniel Jacobowitz
2005-04-29 7:07 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01c54bc1$Blat.v2.4$35ba4ba0@zahav.net.il' \
--to=eliz@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox