[RFC] unsigned32 and unsigned64 is multiply defined in sim-types.h.

[RFC] unsigned32 and unsigned64 is multiply defined in sim-types.h.

[Manoj Iyer]

This patch fixes what appears to be a typo in the hearder file, where for
__ALPHA__, unsigned32 and unsigned64 gets multiply defined in sim-types.h.
This is caught by the xlc compiler, and it exits with an error saying that
these vars are already defined. Please review and ok to commit.

----------------------------------------------------------------------------

2005-04-19  Manoj Iyer  <manjo@austin.ibm.com>
        * sim-types.h: Changed unsigned32 and unsigned64 to signed32
        and signed64.

--- src/sim/common/sim-types.h	2002-11-22 19:12:05.000000000 -0600
+++ new/src/sim/common/sim-types.h	2005-04-20 09:52:45.000000000 -0500
@@ -112,11 +112,11 @@ typedef struct { signed64 a[2]; } signed
 typedef signed char signed8;
 typedef signed short signed16;
 #if defined (__ALPHA__)
-typedef signed int unsigned32;
-typedef signed long unsigned64;
+typedef signed int signed32;
+typedef signed long signed64;
 #else
-typedef signed long unsigned32;
-typedef signed long long unsigned64;
+typedef signed long signed32;
+typedef signed long long signed64;
 #endif

 typedef unsigned char unsigned8;

-----
manjo
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ Cogito ergo sum                                                          +
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Re: [RFC] unsigned32 and unsigned64 is multiply defined in sim-types.h.

[Daniel Jacobowitz]

On Wed, Apr 20, 2005 at 10:01:52AM -0500, Manoj Iyer wrote:
> 
> This patch fixes what appears to be a typo in the hearder file, where for
> __ALPHA__, unsigned32 and unsigned64 gets multiply defined in sim-types.h.
> This is caught by the xlc compiler, and it exits with an error saying that
> these vars are already defined. Please review and ok to commit.
> 
> ----------------------------------------------------------------------------
> 
> 2005-04-19  Manoj Iyer  <manjo@austin.ibm.com>
>         * sim-types.h: Changed unsigned32 and unsigned64 to signed32
>         and signed64.

Yes, this is OK.  Thanks.  Please update the copyright year on this
file when you commit it to include 2005.

-- 
Daniel Jacobowitz
CodeSourcery, LLC

Re: [RFC] unsigned32 and unsigned64 is multiply defined in sim-types.h.

[Manoj Iyer]

/* The common simulator framework for GDB, the GNU Debugger.

   Copyright 2002, 2005 Free Software Foundation, Inc.

   Contributed by Andrew Cagney and Red Hat.

   This file is part of GDB.

Does that look ok?


-----
manjo
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ Cogito ergo sum                                                          +
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

On Wed, 20 Apr 2005, Daniel Jacobowitz wrote:

> On Wed, Apr 20, 2005 at 10:01:52AM -0500, Manoj Iyer wrote:
> >
> > This patch fixes what appears to be a typo in the hearder file, where for
> > __ALPHA__, unsigned32 and unsigned64 gets multiply defined in sim-types.h.
> > This is caught by the xlc compiler, and it exits with an error saying that
> > these vars are already defined. Please review and ok to commit.
> >
> > ----------------------------------------------------------------------------
> >
> > 2005-04-19  Manoj Iyer  <manjo@austin.ibm.com>
> >         * sim-types.h: Changed unsigned32 and unsigned64 to signed32
> >         and signed64.
>
> Yes, this is OK.  Thanks.  Please update the copyright year on this
> file when you commit it to include 2005.
>
> --
> Daniel Jacobowitz
> CodeSourcery, LLC
>

Re: [RFC] unsigned32 and unsigned64 is multiply defined in sim-types.h.

[Daniel Jacobowitz]

On Wed, Apr 20, 2005 at 10:15:23AM -0500, Manoj Iyer wrote:
> 
> /* The common simulator framework for GDB, the GNU Debugger.
> 
>    Copyright 2002, 2005 Free Software Foundation, Inc.
> 
>    Contributed by Andrew Cagney and Red Hat.
> 
>    This file is part of GDB.
> 
> Does that look ok?

Yes, thanks.


-- 
Daniel Jacobowitz
CodeSourcery, LLC

Re: [RFC] unsigned32 and unsigned64 is multiply defined in sim-types.h.

[Mark Kettenis]

   Date: Wed, 20 Apr 2005 10:01:52 -0500 (CDT)
   From: Manoj Iyer <manjo@austin.ibm.com>

   --- src/sim/common/sim-types.h	2002-11-22 19:12:05.000000000 -0600
   +++ new/src/sim/common/sim-types.h	2005-04-20 09:52:45.000000000 -0500
   @@ -112,11 +112,11 @@ typedef struct { signed64 a[2]; } signed
    typedef signed char signed8;
    typedef signed short signed16;
    #if defined (__ALPHA__)
   -typedef signed int unsigned32;
   -typedef signed long unsigned64;
   +typedef signed int signed32;
   +typedef signed long signed64;
    #else
   -typedef signed long unsigned32;
   -typedef signed long long unsigned64;
   +typedef signed long signed32;
   +typedef signed long long signed64;
    #endif

    typedef unsigned char unsigned8;

B.t.w. this whole bit of code looks highly suspicious (but that's not
your fault Manjo).  It looks as if this implies the alpha is still the
only 64-bit architecture around.

Mark

Re: [RFC] unsigned32 and unsigned64 is multiply defined in sim-types.h.

[Manoj Iyer]

oh! I dint even think of it in that angle... u have a good point there
mark.


-----
manjo
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ Cogito ergo sum                                                          +
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

On Thu, 21 Apr 2005, Mark Kettenis wrote:

>    Date: Wed, 20 Apr 2005 10:01:52 -0500 (CDT)
>    From: Manoj Iyer <manjo@austin.ibm.com>
>
>    --- src/sim/common/sim-types.h	2002-11-22 19:12:05.000000000 -0600
>    +++ new/src/sim/common/sim-types.h	2005-04-20 09:52:45.000000000 -0500
>    @@ -112,11 +112,11 @@ typedef struct { signed64 a[2]; } signed
>     typedef signed char signed8;
>     typedef signed short signed16;
>     #if defined (__ALPHA__)
>    -typedef signed int unsigned32;
>    -typedef signed long unsigned64;
>    +typedef signed int signed32;
>    +typedef signed long signed64;
>     #else
>    -typedef signed long unsigned32;
>    -typedef signed long long unsigned64;
>    +typedef signed long signed32;
>    +typedef signed long long signed64;
>     #endif
>
>     typedef unsigned char unsigned8;
>
> B.t.w. this whole bit of code looks highly suspicious (but that's not
> your fault Manjo).  It looks as if this implies the alpha is still the
> only 64-bit architecture around.
>
> Mark
>
>

Re: [RFC] unsigned32 and unsigned64 is multiply defined in sim-types.h.

[Daniel Jacobowitz]

On Thu, Apr 21, 2005 at 12:06:49AM +0200, Mark Kettenis wrote:
>    Date: Wed, 20 Apr 2005 10:01:52 -0500 (CDT)
>    From: Manoj Iyer <manjo@austin.ibm.com>
> 
>    --- src/sim/common/sim-types.h	2002-11-22 19:12:05.000000000 -0600
>    +++ new/src/sim/common/sim-types.h	2005-04-20 09:52:45.000000000 -0500
>    @@ -112,11 +112,11 @@ typedef struct { signed64 a[2]; } signed
>     typedef signed char signed8;
>     typedef signed short signed16;
>     #if defined (__ALPHA__)
>    -typedef signed int unsigned32;
>    -typedef signed long unsigned64;
>    +typedef signed int signed32;
>    +typedef signed long signed64;
>     #else
>    -typedef signed long unsigned32;
>    -typedef signed long long unsigned64;
>    +typedef signed long signed32;
>    +typedef signed long long signed64;
>     #endif
> 
>     typedef unsigned char unsigned8;
> 
> B.t.w. this whole bit of code looks highly suspicious (but that's not
> your fault Manjo).  It looks as if this implies the alpha is still the
> only 64-bit architecture around.

It's also in a not-GNUC and not-MSVC block.  I doubt any of this works
especially well - although as a point of interest to Manoj, it probably
won't work on xlC if xlC supports PPC64.

-- 
Daniel Jacobowitz
CodeSourcery, LLC