From: Daniel Jacobowitz <drow@false.org>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] Eliminate deprecated_show_value_hack from remote.c
Date: Wed, 06 Apr 2005 20:59:00 -0000 [thread overview]
Message-ID: <20050406205942.GA22779@nevyn.them.org> (raw)
In-Reply-To: <20050406135537.0ebe7edc@ironwood.lan>
On Wed, Apr 06, 2005 at 01:55:37PM -0700, Kevin Buettner wrote:
> The patch below eliminates all calls to deprecated_show_value_hack()
> from remote.c.
>
> I considered adding the fprint_filtered() statement which is now in
> the new show_remote_protocol_packet_cmd() to show_packet_config_cmd(),
> but I found one other call to this latter function which didn't also
> want/need the value printed. This is why I created a brand new
> function.
>
> Comments?
> + fprintf_filtered (file,
> + _("Current use of remote protocol `%s' (%s) is %s.\n"),
> + config->name, config->title, value);
Do you need the word "packet" here? It looks like name will be simply
'p'. Otherwise, thank you for doing this!
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-04-06 20:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-06 20:55 Kevin Buettner
2005-04-06 20:59 ` Daniel Jacobowitz [this message]
2005-04-06 21:40 ` Kevin Buettner
2005-04-14 19:38 ` Daniel Jacobowitz
2005-04-15 16:22 ` Kevin Buettner
2005-04-15 17:20 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050406205942.GA22779@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox