From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5432 invoked by alias); 6 Apr 2005 20:59:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5407 invoked from network); 6 Apr 2005 20:59:43 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 6 Apr 2005 20:59:43 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DJHcl-0005xC-84; Wed, 06 Apr 2005 16:59:43 -0400 Date: Wed, 06 Apr 2005 20:59:00 -0000 From: Daniel Jacobowitz To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] Eliminate deprecated_show_value_hack from remote.c Message-ID: <20050406205942.GA22779@nevyn.them.org> Mail-Followup-To: Kevin Buettner , gdb-patches@sources.redhat.com References: <20050406135537.0ebe7edc@ironwood.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050406135537.0ebe7edc@ironwood.lan> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00057.txt.bz2 On Wed, Apr 06, 2005 at 01:55:37PM -0700, Kevin Buettner wrote: > The patch below eliminates all calls to deprecated_show_value_hack() > from remote.c. > > I considered adding the fprint_filtered() statement which is now in > the new show_remote_protocol_packet_cmd() to show_packet_config_cmd(), > but I found one other call to this latter function which didn't also > want/need the value printed. This is why I created a brand new > function. > > Comments? > + fprintf_filtered (file, > + _("Current use of remote protocol `%s' (%s) is %s.\n"), > + config->name, config->title, value); Do you need the word "packet" here? It looks like name will be simply 'p'. Otherwise, thank you for doing this! -- Daniel Jacobowitz CodeSourcery, LLC