From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: jimb@redhat.com
Cc: drow@false.org, gdb-patches@sources.redhat.com
Subject: Re: RFC: Add 'double' member to 64-bit vector register type
Date: Wed, 06 Apr 2005 07:09:00 -0000 [thread overview]
Message-ID: <200504060708.j3678o1G030940@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <vt28y3xw4c0.fsf@zenia.home> (message from Jim Blandy on 05 Apr 2005 11:55:43 -0500)
From: Jim Blandy <jimb@redhat.com>
Date: 05 Apr 2005 11:55:43 -0500
Mark Kettenis <mark.kettenis@xs4all.nl> writes:
> Date: Sat, 19 Mar 2005 21:33:07 -0500
> From: Daniel Jacobowitz <drow@false.org>
>
> On Sat, Mar 19, 2005 at 04:13:12PM -0500, Jim Blandy wrote:
> > Well, that brings up the other thought --- since the set of types
> > useful to include in a vector register really depends on the
> > architecture, wouldn't it be better to just export the convenience
> > functions for constructing these types from gdbtypes.c and then let
> > architectures build ones that actually suit their needs?
>
> My inclination is "yes". Anybody else?
>
> I agree.
Getting back to this...
Here's a patch to move the IA-32 vector types out of gdbtypes.h. The
PowerPC Altivec and SPE types are a little more work, since they
need to be per-architecture, so I'll leave that to a separate patch.
How does this look?
Looks fine to me, except for one nit: can you remove the "excessive"
spacing (one blank line between functions is more than enough,
especially since all the new stuff logically belongs together).
Mark
next prev parent reply other threads:[~2005-04-06 7:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-19 6:17 Jim Blandy
2005-03-19 15:37 ` Daniel Jacobowitz
2005-03-19 21:17 ` Jim Blandy
2005-03-20 2:33 ` Daniel Jacobowitz
2005-03-20 11:14 ` Mark Kettenis
2005-04-05 16:58 ` Jim Blandy
2005-04-06 7:09 ` Mark Kettenis [this message]
2005-04-07 5:00 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200504060708.j3678o1G030940@elgar.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox