From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4822 invoked by alias); 6 Apr 2005 07:09:23 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4715 invoked from network); 6 Apr 2005 07:09:14 -0000 Received: from unknown (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org with SMTP; 6 Apr 2005 07:09:14 -0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j3678o3Q020867; Wed, 6 Apr 2005 09:08:50 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.3/8.13.3) with ESMTP id j3678oFS024540; Wed, 6 Apr 2005 09:08:50 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.3/8.13.3/Submit) id j3678o1G030940; Wed, 6 Apr 2005 09:08:50 +0200 (CEST) Date: Wed, 06 Apr 2005 07:09:00 -0000 Message-Id: <200504060708.j3678o1G030940@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: jimb@redhat.com CC: drow@false.org, gdb-patches@sources.redhat.com In-reply-to: (message from Jim Blandy on 05 Apr 2005 11:55:43 -0500) Subject: Re: RFC: Add 'double' member to 64-bit vector register type References: <20050319153709.GA4659@nevyn.them.org> <20050320023307.GA12519@nevyn.them.org> <200503201114.j2KBE12K023890@elgar.sibelius.xs4all.nl> X-SW-Source: 2005-04/txt/msg00051.txt.bz2 From: Jim Blandy Date: 05 Apr 2005 11:55:43 -0500 Mark Kettenis writes: > Date: Sat, 19 Mar 2005 21:33:07 -0500 > From: Daniel Jacobowitz > > On Sat, Mar 19, 2005 at 04:13:12PM -0500, Jim Blandy wrote: > > Well, that brings up the other thought --- since the set of types > > useful to include in a vector register really depends on the > > architecture, wouldn't it be better to just export the convenience > > functions for constructing these types from gdbtypes.c and then let > > architectures build ones that actually suit their needs? > > My inclination is "yes". Anybody else? > > I agree. Getting back to this... Here's a patch to move the IA-32 vector types out of gdbtypes.h. The PowerPC Altivec and SPE types are a little more work, since they need to be per-architecture, so I'll leave that to a separate patch. How does this look? Looks fine to me, except for one nit: can you remove the "excessive" spacing (one blank line between functions is more than enough, especially since all the new stuff logically belongs together). Mark