Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* PATCH: fix link error for an all-targets libbfd
@ 2005-03-14  2:36 Ben Elliston
  2005-03-14  2:49 ` Daniel Jacobowitz
  0 siblings, 1 reply; 3+ messages in thread
From: Ben Elliston @ 2005-03-14  2:36 UTC (permalink / raw)
  To: gdb-patches

[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]

When linking GDB against an "all-targets" version of libopcodes and libbfd, link
errors occur due to calls from opcodes->bfd.  Since bfd is a lower level library, it
should be linked after libopcodes.  This patch does just that.  Okay for mainline?

2005-03-14  Ben Elliston  <bje@au.ibm.com>

        * Makefile.in (CLIBS): Link libbfd after libopcodes, as it is a
        more primitive library.

Index: Makefile.in
===================================================================
RCS file: /home/bje/src-cvs/src/gdb/Makefile.in,v
retrieving revision 1.705
diff -u -p -r1.705 Makefile.in
--- Makefile.in 11 Mar 2005 02:24:20 -0000      1.705
+++ Makefile.in 14 Mar 2005 02:33:42 -0000
@@ -372,7 +372,7 @@ INTERNAL_LDFLAGS = $(CFLAGS) $(GLOBAL_CF
  INSTALLED_LIBS=-lbfd -lreadline -lopcodes -liberty \
         $(XM_CLIBS) $(TM_CLIBS) $(NAT_CLIBS) $(GDBTKLIBS) @LIBS@ \
         -lintl -liberty
-CLIBS = $(SIM) $(BFD) $(READLINE) $(OPCODES) $(INTL) $(LIBIBERTY) \
+CLIBS = $(SIM) $(READLINE) $(OPCODES) $(BFD) $(INTL) $(LIBIBERTY) \
         $(XM_CLIBS) $(TM_CLIBS) $(NAT_CLIBS) $(GDBTKLIBS) @LIBS@ \
         $(LIBICONV) \
         $(LIBIBERTY) $(WIN32LIBS)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: PATCH: fix link error for an all-targets libbfd
  2005-03-14  2:36 PATCH: fix link error for an all-targets libbfd Ben Elliston
@ 2005-03-14  2:49 ` Daniel Jacobowitz
  2005-03-14  3:13   ` Ben Elliston
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Jacobowitz @ 2005-03-14  2:49 UTC (permalink / raw)
  To: Ben Elliston; +Cc: gdb-patches

On Mon, Mar 14, 2005 at 01:36:09PM +1100, Ben Elliston wrote:
> When linking GDB against an "all-targets" version of libopcodes and libbfd, 
> link
> errors occur due to calls from opcodes->bfd.  Since bfd is a lower level 
> library, it
> should be linked after libopcodes.  This patch does just that.  Okay for 
> mainline?
> 
> 2005-03-14  Ben Elliston  <bje@au.ibm.com>
> 
>        * Makefile.in (CLIBS): Link libbfd after libopcodes, as it is a
>        more primitive library.

Makes sense.  This is OK.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: PATCH: fix link error for an all-targets libbfd
  2005-03-14  2:49 ` Daniel Jacobowitz
@ 2005-03-14  3:13   ` Ben Elliston
  0 siblings, 0 replies; 3+ messages in thread
From: Ben Elliston @ 2005-03-14  3:13 UTC (permalink / raw)
  To: Daniel Jacobowitz; +Cc: gdb-patches

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

>>2005-03-14  Ben Elliston  <bje@au.ibm.com>
>>
>>       * Makefile.in (CLIBS): Link libbfd after libopcodes, as it is a
>>       more primitive library.
>
> Makes sense.  This is OK.

Thanks; applied.

Ben

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-03-14  3:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-03-14  2:36 PATCH: fix link error for an all-targets libbfd Ben Elliston
2005-03-14  2:49 ` Daniel Jacobowitz
2005-03-14  3:13   ` Ben Elliston

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox