Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Paul Schlie <schlie@comcast.net>
Cc: Orjan Friberg <orjan.friberg@axis.com>, gdb-patches@sources.redhat.com
Subject: Re: [gdbserver/patch] Z packet support
Date: Sun, 30 Jan 2005 20:38:00 -0000	[thread overview]
Message-ID: <20050130203830.GA7506@nevyn.them.org> (raw)
In-Reply-To: <BE22A5D3.8D4E%schlie@comcast.net>

On Sun, Jan 30, 2005 at 02:55:15PM -0500, Paul Schlie wrote:
> (with respect to "redundant", you're likely correct in questioning my use
>  of that word, as I had mistakenly assumed that many of the declarations
>  in server.h, also logically appeared in their corresponding source file
>  headers; as opposed to being disassociated with them.)
> 
>  where for for example in server.h:
> 
>    /* Functions from remote-utils.c */
> 
>    int putpkt (char *buf);
>    ...
> 
> where putpkt implementations matching that prototype are defined in both
> remote.c and remote-utils.c, but prototyped in remote.h, and server.h;
> where it would have seemed simpler and more consistent to declare public
> prototypes in the corresponding header files associated with a function's
> implementation, which may then be included by source files as required,
> thereby establishing a clear dependency, which would seem to help make
> file dependency generation, etc. not to mention general clarity affecting
> maintainability of the of the sources. (as just an opinion)

You seem to be somewhat confused about one thing, which explains your
comment better.  GDB and gdbserver are completely independent programs. 
There are a few bits of shared code, e.g. the signals/ directory, but
they are compiled separately for each.

"remote.h" and "remote.c" are part of GDB.  "server.h" and
"remote-utils.c" are is part of gdbserver.  Therefore, there is no
redundancy; the overlap in function names is basically coincidence.
server.h provides prototypes for most of the target-independent files
in gdbserver.

-- 
Daniel Jacobowitz


  reply	other threads:[~2005-01-30 20:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-30 15:32 Paul Schlie
2005-01-30 15:38 ` Daniel Jacobowitz
2005-01-30 15:57   ` Paul Schlie
2005-01-30 17:36     ` Daniel Jacobowitz
2005-01-30 19:55       ` Paul Schlie
2005-01-30 20:38         ` Daniel Jacobowitz [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-12-01 15:13 Orjan Friberg
2004-12-07  2:44 ` Daniel Jacobowitz
2004-12-16 18:46   ` Orjan Friberg
2005-01-12 13:35   ` Orjan Friberg
2005-01-30  4:40     ` Daniel Jacobowitz
2005-02-01 12:09       ` Orjan Friberg
2005-02-14 14:42         ` Orjan Friberg
2005-02-24 20:53         ` Daniel Jacobowitz
2005-05-12 12:34           ` Orjan Friberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050130203830.GA7506@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=orjan.friberg@axis.com \
    --cc=schlie@comcast.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox