Re: [gdbserver/patch] Z packet support

[Daniel Jacobowitz <drow@false.org>]

On Sun, Jan 30, 2005 at 10:32:30AM -0500, Paul Schlie wrote:
> In the spirit of the present structure of the file, might it make
> more sense to actually add decode_Z_packet (... ) to remote-utils.c,
> along with possibly the thread stuff, and use it correspondingly in
> server.c, before it gets out of hand?
> 
> And while at it, move CORE_ADDR tweak server.h to wherever it likely
> belongs? (and/or redefine it to void* if more appropriate)?
> 
>  /* FIXME: This should probably be autoconf'd for.  It's an integer type at
>    least the size of a (void *).  */
>   typedef long long CORE_ADDR;
> 
> 
> And remove redundant declarations from server.h, and include required
> respective headers in server.c
> 
>  /* Functions from remote-utils.c */
>  void decode_M_packet (char *from, CORE_ADDR * mem_addr_ptr,
>               unsigned int *len_ptr, char *to);
>  ...
>  /* Functions from ``signals.c''.  */
>  ...
> 
> ??? (although I know it's easier said than done?)

If you want to make cosmetic structural changes to gdbserver, and
can show that they actually have benefit, then feel free to file a
copyright assignment and submit patches yourself.

As it happens:
  1. I don't care either way.
  2. Please re-read the comment; it should not be void *.  It is also
     required that it be harmless for CORE_ADDR to be too large; see
     MIPS n32 vs n64.
  3. There are nowhere near enough exported functions to justify
     proliferating headers.

-- 
Daniel Jacobowitz