Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Richard Earnshaw <Richard.Earnshaw@buzzard.freeserve.co.uk>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA fix conversion of little-byte big-word floats to doublest
Date: Sun, 05 Dec 2004 15:54:00 -0000	[thread overview]
Message-ID: <20041205015136.GA25952@nevyn.them.org> (raw)
In-Reply-To: <200412042358.iB4Nws2W015496@merlin.buzzard.freeserve.co.uk>

On Sat, Dec 04, 2004 at 11:58:54PM +0000, Richard Earnshaw wrote:
> On Sat, 04 Dec 2004 12:32:57 EST, Daniel Jacobowitz <drow@false.org>  
> wrote:
> > On Sat, Dec 04, 2004 at 05:25:21PM +0000, Richard Earnshaw wrote:
> > > I've just been thinking.
> > > 
> > > The current code (for both conversions to and from doublest) tries to work 
> > > by normalizing the word order to match the byte order.  This clearly makes 
> > > things quite difficult when the number of words involved is variable.
> > > 
> > > I think it would be a more tractable problem to change all this around so 
> > > that the byte order is normalized to match the word order.  This can be 
> > > done by simply repeating a word-normalization step for each word in the 
> > > value.
> > > 
> > > Thoughts?
> > 
> > That sounds good to me - much simpler.
> 
> I withdraw my previous patch and substitute this one.  This should also 
> fix handling of mixed endian formats that are larger than 64 bits.
> 
> Unlike the previous patch this one also correctly handles NaNs; though it 
> appears that nothing in the testsuite currently tests this.

Yes, the revised patch is OK.  Thanks.

-- 
Daniel Jacobowitz


      reply	other threads:[~2004-12-05  1:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-04 15:27 Richard Earnshaw
2004-12-04 15:47 ` Daniel Jacobowitz
2004-12-04 16:01 ` Richard Earnshaw
2004-12-04 16:57   ` Daniel Jacobowitz
2004-12-04 17:23   ` Richard Earnshaw
2004-12-04 17:33   ` Richard Earnshaw
2004-12-04 19:39     ` Daniel Jacobowitz
2004-12-05  1:51     ` Richard Earnshaw
2004-12-05 15:54       ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041205015136.GA25952@nevyn.them.org \
    --to=drow@false.org \
    --cc=Richard.Earnshaw@buzzard.freeserve.co.uk \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox