Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Richard Earnshaw <Richard.Earnshaw@buzzard.freeserve.co.uk>
To: gdb-patches@sources.redhat.com
Cc: Richard.Earnshaw@buzzard.freeserve.co.uk
Subject: RFA fix conversion of little-byte big-word floats to doublest
Date: Sat, 04 Dec 2004 15:27:00 -0000	[thread overview]
Message-ID: <200412041438.iB4Ec0cq017568@merlin.buzzard.freeserve.co.uk> (raw)

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]


This patch fixes a bug in get_field which meant that we incorrectly 
converted mixed-endian floats (ARM FPA style) into the internal doublest 
format.  This short change fixes over 300 testsuite failures in a combined 
arm/thumb testsuite run on arm-elf.

	* doublest.c (get_field): Correctly extract floatformat_littebyte_bigword
	fields.

OK?


[-- Attachment #2: doublest.patch --]
[-- Type: text/x-patch , Size: 859 bytes --]

Index: doublest.c
===================================================================
RCS file: /cvs/src/src/gdb/doublest.c,v
retrieving revision 1.22
diff -p -p -r1.22 doublest.c
*** doublest.c	24 Aug 2004 22:49:27 -0000	1.22
--- doublest.c	4 Dec 2004 14:33:34 -0000
*************** get_field (unsigned char *data, enum flo
*** 94,106 ****
        switch (order)
  	{
  	case floatformat_little:
  	  ++cur_byte;
  	  break;
  	case floatformat_big:
  	  --cur_byte;
  	  break;
- 	case floatformat_littlebyte_bigword:
- 	  break;
  	}
      }
    if (len < sizeof(result) * FLOATFORMAT_CHAR_BIT)
--- 94,105 ----
        switch (order)
  	{
  	case floatformat_little:
+ 	case floatformat_littlebyte_bigword:
  	  ++cur_byte;
  	  break;
  	case floatformat_big:
  	  --cur_byte;
  	  break;
  	}
      }
    if (len < sizeof(result) * FLOATFORMAT_CHAR_BIT)

             reply	other threads:[~2004-12-04 14:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-04 15:27 Richard Earnshaw [this message]
2004-12-04 15:47 ` Daniel Jacobowitz
2004-12-04 16:01 ` Richard Earnshaw
2004-12-04 16:57   ` Daniel Jacobowitz
2004-12-04 17:23   ` Richard Earnshaw
2004-12-04 17:33   ` Richard Earnshaw
2004-12-04 19:39     ` Daniel Jacobowitz
2004-12-05  1:51     ` Richard Earnshaw
2004-12-05 15:54       ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200412041438.iB4Ec0cq017568@merlin.buzzard.freeserve.co.uk \
    --to=richard.earnshaw@buzzard.freeserve.co.uk \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox