From: Mark Kettenis <kettenis@gnu.org>
To: kewarken@qnx.com
Cc: kewarken@qnx.com, gdb-patches@sources.redhat.com
Subject: Re: Ping: [patch] general updates and improvements to QNX NTO support
Date: Fri, 03 Dec 2004 16:17:00 -0000 [thread overview]
Message-ID: <200412031617.iB3GHFN3020509@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <41B0905D.7070408@qnx.com> (message from Kris Warkentin on Fri, 03 Dec 2004 11:12:14 -0500)
Date: Fri, 03 Dec 2004 11:12:14 -0500
From: Kris Warkentin <kewarken@qnx.com>
Weekly ping. It's really not that bad....I ran gdb_indent.sh on
it....it's only affecting QNX specific stuff....I tested it on Windows,
Linux and Neutrino...
It is bad. It defines variables in a header file. That's
unacceptable. What's your motivation for getting rid of `struct
nto_target_ops' in the first place? Seems like a step in the wrong
direction to me.
Please fix this, then resubmit. I promise to look at it in a timely
fashion if you do.
Mark
next prev parent reply other threads:[~2004-12-03 16:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-19 20:47 Kris Warkentin
2004-11-26 20:37 ` Ping: " Kris Warkentin
2004-12-03 16:09 ` Kris Warkentin
2004-12-03 16:17 ` Mark Kettenis [this message]
2004-12-03 17:01 ` Kris Warkentin
2004-12-03 17:23 ` Kris Warkentin
2004-12-03 17:44 ` Mark Kettenis
2004-12-06 16:53 ` Revised: " Kris Warkentin
2004-12-09 0:52 ` Mark Kettenis
2004-12-09 15:45 ` Kris Warkentin
2004-12-09 22:31 ` Mark Kettenis
2004-12-03 23:16 Ping: " Kris Warkentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200412031617.iB3GHFN3020509@elgar.sibelius.xs4all.nl \
--to=kettenis@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=kewarken@qnx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox