From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16839 invoked by alias); 3 Dec 2004 16:17:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16791 invoked from network); 3 Dec 2004 16:17:27 -0000 Received: from unknown (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org with SMTP; 3 Dec 2004 16:17:27 -0000 Received: from elgar.sibelius.xs4all.nl (elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id iB3GHK8a012218; Fri, 3 Dec 2004 17:17:20 +0100 (CET) Received: from elgar.sibelius.xs4all.nl (localhost [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.12.6p3/8.12.6) with ESMTP id iB3GHJol020512; Fri, 3 Dec 2004 17:17:19 +0100 (CET) (envelope-from kettenis@elgar.sibelius.xs4all.nl) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.12.6p3/8.12.6/Submit) id iB3GHFN3020509; Fri, 3 Dec 2004 17:17:15 +0100 (CET) Date: Fri, 03 Dec 2004 16:17:00 -0000 Message-Id: <200412031617.iB3GHFN3020509@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: kewarken@qnx.com CC: kewarken@qnx.com, gdb-patches@sources.redhat.com In-reply-to: <41B0905D.7070408@qnx.com> (message from Kris Warkentin on Fri, 03 Dec 2004 11:12:14 -0500) Subject: Re: Ping: [patch] general updates and improvements to QNX NTO support References: <419E5B3C.3020209@qnx.com> <41A794A8.9090008@qnx.com> <41B0905D.7070408@qnx.com> X-SW-Source: 2004-12/txt/msg00064.txt.bz2 Date: Fri, 03 Dec 2004 11:12:14 -0500 From: Kris Warkentin Weekly ping. It's really not that bad....I ran gdb_indent.sh on it....it's only affecting QNX specific stuff....I tested it on Windows, Linux and Neutrino... It is bad. It defines variables in a header file. That's unacceptable. What's your motivation for getting rid of `struct nto_target_ops' in the first place? Seems like a step in the wrong direction to me. Please fix this, then resubmit. I promise to look at it in a timely fashion if you do. Mark