[patch/rfa] fix thread_check test

[patch/rfa] fix thread_check test

[Randolph Chung]

i don't think this has ever worked for anybody... :)

The test program name in this test case doesn't match what's in the
testsuite. The regular expression was wrong as well. 

Patch tested on hppa-linux. ok to check in? this should give (almost)
everbody 2 more PASSes on their testsuite results.

randolph


2004-11-23  Randolph Chung  <tausq@debian.org>

	testsuite/

	* gdb.threads/thread_check.exp: Use $srcfile for test program name
	instead of "tbug".  Fix regexp to work properly with gdb_test.

Index: testsuite/gdb.threads/thread_check.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/thread_check.exp,v
retrieving revision 1.1
diff -u -p -r1.1 thread_check.exp
--- testsuite/gdb.threads/thread_check.exp	31 Aug 2004 20:01:13 -0000	1.1
+++ testsuite/gdb.threads/thread_check.exp	23 Nov 2004 23:13:27 -0000
@@ -27,7 +27,7 @@
 #   in ptrace system call.
 #
 # Test Strategy:
-# - tbug.c creates 2 threads
+# - thread_check.c creates 2 threads
 # - start gdb 
 # - create 2 breakpoints #1 main() #2 tf() (the thread function)
 # - run gdb till #1 main() breakpoint is reached
@@ -74,14 +74,14 @@ gdb_test "break tf" \
 # continue to tf() breakpoint #2
 #
 gdb_test "continue" \
-    ".*Breakpoint 2.*tf.* at .*tbug.* .*\r\n.*$gdb_prompt $" \
+     ".*Breakpoint 2,.*tf.*at.*$srcfile:.*" \
      "continue to tf"
 
 #   
 # backtrace from thread function.
 #
 gdb_test "backtrace" \
-    "#0 .*tf .*at .*tbug.*" \
+    "#0 .*tf .*at .*$srcfile:.*" \
     "backtrace from thread function"
 
 
-- 
Randolph Chung
Debian GNU/Linux Developer, hppa/ia64 ports
http://www.tausq.org/

Re: [patch/rfa] fix thread_check test

[Daniel Jacobowitz]

On Tue, Nov 23, 2004 at 03:15:59PM -0800, Randolph Chung wrote:
> i don't think this has ever worked for anybody... :)
> 
> The test program name in this test case doesn't match what's in the
> testsuite. The regular expression was wrong as well. 
> 
> Patch tested on hppa-linux. ok to check in? this should give (almost)
> everbody 2 more PASSes on their testsuite results.
> 
> randolph
> 
> 
> 2004-11-23  Randolph Chung  <tausq@debian.org>
> 
> 	testsuite/
> 
> 	* gdb.threads/thread_check.exp: Use $srcfile for test program name
> 	instead of "tbug".  Fix regexp to work properly with gdb_test.

Yes, please check this in.


-- 
Daniel Jacobowitz