From: Mark Kettenis <kettenis@gnu.org>
To: brobecker@gnat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [COMMIT] Fix compilations problem on sparc-sun-solaris2.9
Date: Mon, 15 Nov 2004 18:11:00 -0000 [thread overview]
Message-ID: <200411151811.iAFIB1tB000902@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <20041115162905.GC981@gnat.com> (message from Joel Brobecker on Mon, 15 Nov 2004 08:29:05 -0800)
Date: Mon, 15 Nov 2004 08:29:05 -0800
From: Joel Brobecker <brobecker@gnat.com>
> Fallout from the recent term.h fix related to Solaris header
> brandamage. AFAICT "terminal.h" isn't necessary at all in tui-io.c,
> so I removed it. Let's hope there isn't another braindamages systems
> that needs it.
Do you remember the error that you had without your fix? On our side,
we had a failure on this platform too:
> In file included from gdb_curses.h:38,
> from tui/tui-data.h:29,
> from tui/tui-io.c:33:
> /usr/include/term.h:1060: field `Ottyb' has incomplete type
> /usr/include/term.h:1061: field `Nttyb' has incomplete type
> make[1]: *** [tui-io.o] Error 1
Yup, that's exactly the problem I was getting.
We had a patch that I was testing on all our native configuration.
It looks like I can dump it, but I wanted to make sure you address
the same problem.
I did consider something like your patch too, but it didn't feel
right, although it probably is a bit more robust. We can always
consider something like that if the need arises.
Cheers,
Mark
prev parent reply other threads:[~2004-11-15 18:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-15 9:48 Mark Kettenis
2004-11-15 16:29 ` Joel Brobecker
2004-11-15 18:11 ` Mark Kettenis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200411151811.iAFIB1tB000902@elgar.sibelius.xs4all.nl \
--to=kettenis@gnu.org \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox