Re: [COMMIT] Fix compilations problem on sparc-sun-solaris2.9

[Joel Brobecker <brobecker@gnat.com>]

[-- Attachment #1: Type: text/plain, Size: 788 bytes --]

> Fallout from the recent term.h fix related to Solaris header
> brandamage.  AFAICT "terminal.h" isn't necessary at all in tui-io.c,
> so I removed it.  Let's hope there isn't another braindamages systems
> that needs it.

Do you remember the error that you had without your fix? On our side,
we had a failure on this platform too:

> In file included from gdb_curses.h:38,
>                  from tui/tui-data.h:29,
>                  from tui/tui-io.c:33:
> /usr/include/term.h:1060: field `Ottyb' has incomplete type
> /usr/include/term.h:1061: field `Nttyb' has incomplete type
> make[1]: *** [tui-io.o] Error 1

We had a patch that I was testing on all our native configuration.
It looks like I can dump it, but I wanted to make sure you address
the same problem.

Thanks!
-- 
Joel

[-- Attachment #2: gdb_curses.diff --]
[-- Type: text/plain, Size: 889 bytes --]

Index: gdb/gdb_curses.h
===================================================================
RCS file: /cvs/src/src/gdb/gdb_curses.h,v
retrieving revision 1.4
diff -c -p -r1.4 gdb_curses.h
*** gdb/gdb_curses.h	9 Nov 2004 00:59:03 -0000	1.4
--- gdb/gdb_curses.h	12 Nov 2004 02:35:21 -0000
***************
*** 35,40 ****
--- 35,49 ----
  #if defined (HAVE_NCURSES_TERM_H)
  #include <ncurses/term.h>
  #elif defined (HAVE_TERM_H)
+ #ifdef HAVE_TERMIO_H
+ /* Some definitions from termio are sometimes needed for term.h.
+    For instance, on Solaris 2.8, strm term contains two fields
+    named Ottyb and Nttyb of type SGTTY, which is defined as a
+    typedef of struct termio in term.h.  Without including term.h,
+    the compiler has an incomplete definition of the type of these
+    two fields, and aborts the builds.  */
+ #include <termio.h>
+ #endif
  #include <term.h>
  #endif