From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24214 invoked by alias); 15 Nov 2004 16:29:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24170 invoked from network); 15 Nov 2004 16:29:06 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sourceware.org with SMTP; 15 Nov 2004 16:29:06 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 43ADF47DA0; Mon, 15 Nov 2004 08:29:05 -0800 (PST) Date: Mon, 15 Nov 2004 16:29:00 -0000 From: Joel Brobecker To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [COMMIT] Fix compilations problem on sparc-sun-solaris2.9 Message-ID: <20041115162905.GC981@gnat.com> References: <200411150947.iAF9lUWT018125@juw15.nfra.nl> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Nq2Wo0NMKNjxTN9z" Content-Disposition: inline In-Reply-To: <200411150947.iAF9lUWT018125@juw15.nfra.nl> User-Agent: Mutt/1.4i X-SW-Source: 2004-11/txt/msg00314.txt.bz2 --Nq2Wo0NMKNjxTN9z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 788 > Fallout from the recent term.h fix related to Solaris header > brandamage. AFAICT "terminal.h" isn't necessary at all in tui-io.c, > so I removed it. Let's hope there isn't another braindamages systems > that needs it. Do you remember the error that you had without your fix? On our side, we had a failure on this platform too: > In file included from gdb_curses.h:38, > from tui/tui-data.h:29, > from tui/tui-io.c:33: > /usr/include/term.h:1060: field `Ottyb' has incomplete type > /usr/include/term.h:1061: field `Nttyb' has incomplete type > make[1]: *** [tui-io.o] Error 1 We had a patch that I was testing on all our native configuration. It looks like I can dump it, but I wanted to make sure you address the same problem. Thanks! -- Joel --Nq2Wo0NMKNjxTN9z Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="gdb_curses.diff" Content-length: 889 Index: gdb/gdb_curses.h =================================================================== RCS file: /cvs/src/src/gdb/gdb_curses.h,v retrieving revision 1.4 diff -c -p -r1.4 gdb_curses.h *** gdb/gdb_curses.h 9 Nov 2004 00:59:03 -0000 1.4 --- gdb/gdb_curses.h 12 Nov 2004 02:35:21 -0000 *************** *** 35,40 **** --- 35,49 ---- #if defined (HAVE_NCURSES_TERM_H) #include #elif defined (HAVE_TERM_H) + #ifdef HAVE_TERMIO_H + /* Some definitions from termio are sometimes needed for term.h. + For instance, on Solaris 2.8, strm term contains two fields + named Ottyb and Nttyb of type SGTTY, which is defined as a + typedef of struct termio in term.h. Without including term.h, + the compiler has an incomplete definition of the type of these + two fields, and aborts the builds. */ + #include + #endif #include #endif --Nq2Wo0NMKNjxTN9z--