From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12022 invoked by alias); 15 Nov 2004 18:11:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11937 invoked from network); 15 Nov 2004 18:11:05 -0000 Received: from unknown (HELO walton.sibelius.xs4all.nl) (82.92.89.47) by sourceware.org with SMTP; 15 Nov 2004 18:11:05 -0000 Received: from elgar.sibelius.xs4all.nl (elgar.sibelius.xs4all.nl [192.168.0.2]) by walton.sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id iAFIB2C3018875; Mon, 15 Nov 2004 19:11:02 +0100 (CET) Received: from elgar.sibelius.xs4all.nl (localhost [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.12.6p3/8.12.6) with ESMTP id iAFIB2JT000905; Mon, 15 Nov 2004 19:11:02 +0100 (CET) (envelope-from kettenis@elgar.sibelius.xs4all.nl) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.12.6p3/8.12.6/Submit) id iAFIB1tB000902; Mon, 15 Nov 2004 19:11:01 +0100 (CET) Date: Mon, 15 Nov 2004 18:11:00 -0000 Message-Id: <200411151811.iAFIB1tB000902@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: brobecker@gnat.com CC: gdb-patches@sources.redhat.com In-reply-to: <20041115162905.GC981@gnat.com> (message from Joel Brobecker on Mon, 15 Nov 2004 08:29:05 -0800) Subject: Re: [COMMIT] Fix compilations problem on sparc-sun-solaris2.9 References: <200411150947.iAF9lUWT018125@juw15.nfra.nl> <20041115162905.GC981@gnat.com> X-SW-Source: 2004-11/txt/msg00315.txt.bz2 Date: Mon, 15 Nov 2004 08:29:05 -0800 From: Joel Brobecker > Fallout from the recent term.h fix related to Solaris header > brandamage. AFAICT "terminal.h" isn't necessary at all in tui-io.c, > so I removed it. Let's hope there isn't another braindamages systems > that needs it. Do you remember the error that you had without your fix? On our side, we had a failure on this platform too: > In file included from gdb_curses.h:38, > from tui/tui-data.h:29, > from tui/tui-io.c:33: > /usr/include/term.h:1060: field `Ottyb' has incomplete type > /usr/include/term.h:1061: field `Nttyb' has incomplete type > make[1]: *** [tui-io.o] Error 1 Yup, that's exactly the problem I was getting. We had a patch that I was testing on all our native configuration. It looks like I can dump it, but I wanted to make sure you address the same problem. I did consider something like your patch too, but it didn't feel right, although it probably is a bit more robust. We can always consider something like that if the need arises. Cheers, Mark