From: Daniel Jacobowitz <drow@false.org>
To: Nick Clifton <nickc@redhat.com>
Cc: binutils@sources.redhat.com, gdb-patches@sources.redhat.com,
newlib@sources.redhat.com
Subject: Re: Dejagnu: use -isystem to include system header files.
Date: Thu, 11 Nov 2004 17:00:00 -0000 [thread overview]
Message-ID: <20041111170019.GA9958@nevyn.them.org> (raw)
In-Reply-To: <41938BDF.7040104@redhat.com>
On Thu, Nov 11, 2004 at 03:57:19PM +0000, Nick Clifton wrote:
> Hi Daniel,
>
> >This patch will break in-tree testing for yet other targets. I believe
> >arm-elf was affected - anything which does not set
> >NO_IMPLICIT_EXTERN_C. I discussed this with H-P on the dejagnu list
> >but never figured out a solution, but...
>
> >> * lib/libgloss.exp (newlib_include_flags): Use -isystem, not -I.
> >> (libio_include_flags, g++_include_flags, libstdc++_include_flags,
> >> winsup_include_flags): Ditto.
>
> >... I strongly suspect that g++ and winsup should be left out.
>
>
> Ok - what about this revision to the patched sources based upon Rob
> Savoye's suggestion that -isystem is only needed for newlib includes ?
>
> It appears to work for the xstormy16 port and I did not detect any
> regression for the arm-elf port, so I think that it should be OK.
>
> Assuming that you like this patch, shall I submit it to Rob for
> inclusion in the official sources as well ?
I do like it, and I'd appreciate that!
--
Daniel Jacobowitz
next prev parent reply other threads:[~2004-11-11 17:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m3pt2koaw8.fsf@redhat.com>
2004-11-11 14:22 ` Daniel Jacobowitz
2004-11-11 15:54 ` Nick Clifton
2004-11-11 17:00 ` Daniel Jacobowitz [this message]
2004-11-12 0:25 ` Hans-Peter Nilsson
2004-11-12 0:29 ` Daniel Jacobowitz
2004-11-12 1:30 ` Zack Weinberg
2004-11-17 17:47 Richard Earnshaw
2004-11-18 9:15 ` Nick Clifton
2004-11-18 11:15 ` Richard Earnshaw
2004-11-18 15:56 ` Nick Clifton
2004-11-18 20:07 Richard Earnshaw
2004-11-22 14:05 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041111170019.GA9958@nevyn.them.org \
--to=drow@false.org \
--cc=binutils@sources.redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=newlib@sources.redhat.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox