From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25466 invoked by alias); 11 Nov 2004 17:00:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25294 invoked from network); 11 Nov 2004 17:00:25 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 11 Nov 2004 17:00:25 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1CSIJ2-0002g7-2n; Thu, 11 Nov 2004 12:00:20 -0500 Date: Thu, 11 Nov 2004 17:00:00 -0000 From: Daniel Jacobowitz To: Nick Clifton Cc: binutils@sources.redhat.com, gdb-patches@sources.redhat.com, newlib@sources.redhat.com Subject: Re: Dejagnu: use -isystem to include system header files. Message-ID: <20041111170019.GA9958@nevyn.them.org> Mail-Followup-To: Nick Clifton , binutils@sources.redhat.com, gdb-patches@sources.redhat.com, newlib@sources.redhat.com References: <20041111142237.GA25841@nevyn.them.org> <41938BDF.7040104@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41938BDF.7040104@redhat.com> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-11/txt/msg00233.txt.bz2 On Thu, Nov 11, 2004 at 03:57:19PM +0000, Nick Clifton wrote: > Hi Daniel, > > >This patch will break in-tree testing for yet other targets. I believe > >arm-elf was affected - anything which does not set > >NO_IMPLICIT_EXTERN_C. I discussed this with H-P on the dejagnu list > >but never figured out a solution, but... > > >> * lib/libgloss.exp (newlib_include_flags): Use -isystem, not -I. > >> (libio_include_flags, g++_include_flags, libstdc++_include_flags, > >> winsup_include_flags): Ditto. > > >... I strongly suspect that g++ and winsup should be left out. > > > Ok - what about this revision to the patched sources based upon Rob > Savoye's suggestion that -isystem is only needed for newlib includes ? > > It appears to work for the xstormy16 port and I did not detect any > regression for the arm-elf port, so I think that it should be OK. > > Assuming that you like this patch, shall I submit it to Rob for > inclusion in the official sources as well ? I do like it, and I'd appreciate that! -- Daniel Jacobowitz